Skip to content

Add wire support for IBM Bob#1000

Open
DucNgoQuang wants to merge 1 commit into
rohitg00:mainfrom
DucNgoQuang:feat/bob-wire
Open

Add wire support for IBM Bob#1000
DucNgoQuang wants to merge 1 commit into
rohitg00:mainfrom
DucNgoQuang:feat/bob-wire

Conversation

@DucNgoQuang

@DucNgoQuang DucNgoQuang commented Jul 2, 2026

Copy link
Copy Markdown

Add wire support for IBM Bob

Summary by CodeRabbit

  • New Features
    • Added support for connecting the CLI with Bob as a supported agent.
    • Bob is now included in agent detection and selection flows.
  • Documentation
    • Updated the setup guide to list Bob in the supported agent names for connection setup.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new "bob" connector adapter using createJsonMcpAdapter with home-directory-based detection and config paths, registers it in the connect ADAPTERS list in index.ts, and updates the install runbook to list bob as a supported agent.

Changes

Bob connector support

Layer / File(s) Summary
Adapter definition and registry wiring
src/cli/connect/bob.ts, src/cli/connect/index.ts, INSTALL_FOR_AGENTS.md
New adapter export configured via createJsonMcpAdapter with bob-specific detectDir/configPath, imported and added to the ADAPTERS array, and documented in the install runbook's supported agent list.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding support for IBM Bob in the agent connection flow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/cli/connect/bob.ts`:
- Line 9: The Bob adapter is using the project-level MCP filename instead of the
global settings filename, so update the config path in the bob connector to use
Bob’s global MCP settings file name. In the connect/bob.ts logic that builds the
settings path with join(homedir(), ".bob", "settings", ...), replace the current
mcp.json reference with mcp_settings.json so the adapter writes and verifies the
file Bob actually reads.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fc0674f-06c8-4dcc-9b6d-d9fdd6dee0f2

📥 Commits

Reviewing files that changed from the base of the PR and between 93ae9bc and d94e8e9.

📒 Files selected for processing (3)
  • INSTALL_FOR_AGENTS.md
  • src/cli/connect/bob.ts
  • src/cli/connect/index.ts

Comment thread src/cli/connect/bob.ts
name: "bob",
displayName: "IBM Bob",
detectDir: join(homedir(), ".bob"),
configPath: join(homedir(), ".bob", "settings", "mcp.json"),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

IBM Bob MCP settings file name path mcp_settings.json mcp.json global configuration ~/.bob/settings

💡 Result:

IBM Bob manages Model Context Protocol (MCP) server configurations through two primary levels of JSON-based files. Global Configuration Global settings are stored in mcp_settings.json, which applies configurations across all workspaces [1][2][3]. The standard location for this file is in the user's home directory under the.bob/settings/ subdirectory [4][5]: ~/.bob/settings/mcp_settings.json Note: Depending on the specific environment or installation, some official documentation may refer to the global file simply as ~/.bob/mcp_settings.json [2][3]. Additionally, some IDE-integrated versions of IBM Bob store these settings within application-specific data directories, such as: macOS: ~/Library/Application Support/IBM Bob/User/globalStorage/ibm.bob-code/settings/mcp_settings.json [6] Linux: ~/.config/IBM Bob/User/globalStorage/ibm.bob-code/settings/mcp_settings.json [6] Windows: %APPDATA%\IBM Bob\User\globalStorage\ibm.bob-code\settings\mcp_settings.json [6] Project-Level Configuration Project-specific settings are stored in a file named mcp.json [1][2]. This file is located in the root directory of your project folder [1][3]:.bob/mcp.json If the same MCP server name exists in both global and project configurations, the project-level setting takes precedence [2][3]. You can manage these files directly or through the IBM Bob settings menu, which allows you to open and edit the global or project-specific MCP configurations [1][7]. Changes usually require a restart or reload of IBM Bob to take effect [4][8].

Citations:


🏁 Script executed:

git ls-files | rg '^src/cli/connect/bob\.ts$|^README|bob|mcp'

Repository: rohitg00/agentmemory

Length of output: 1176


🏁 Script executed:

sed -n '1,220p' src/cli/connect/bob.ts

Repository: rohitg00/agentmemory

Length of output: 620


🏁 Script executed:

sed -n '1,260p' src/cli/connect/json-mcp-adapter.ts

Repository: rohitg00/agentmemory

Length of output: 4079


Use Bob’s global MCP settings filename here~/.bob/settings/ should use mcp_settings.json; mcp.json is the project-level name, so this adapter writes and verifies the wrong file and Bob won’t read it.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/cli/connect/bob.ts` at line 9, The Bob adapter is using the project-level
MCP filename instead of the global settings filename, so update the config path
in the bob connector to use Bob’s global MCP settings file name. In the
connect/bob.ts logic that builds the settings path with join(homedir(), ".bob",
"settings", ...), replace the current mcp.json reference with mcp_settings.json
so the adapter writes and verifies the file Bob actually reads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant