Skip to content

fix(pi): avoid stale ctx.ui after async health check #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yulin0629 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −1
Open

fix(pi): avoid stale ctx.ui after async health check #1036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4dfc8
fix(pi): avoid stale ctx.ui after async health check
yulin0629 Jul 9, 2026
3f87702
fix(pi): capture ui once before binding setStatus
yulin0629 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion integrations/pi/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,24 @@ export default function agentmemoryExtension(pi: ExtensionAPI) {
}

async function refreshStatus(ctx: { ui: { setStatus: (key: string, text: string) => void } }) {
// Capture the setter while ctx is still active. After await getHealth(), the
// session may have been replaced/reloaded and ctx.ui would throw stale.
let setStatus: (key: string, text: string) => void;
try {
const ui = ctx.ui;
setStatus = ui.setStatus.bind(ui);
} catch {
return;
}

const health = await getHealth();
lastHealthOk = !!health && (health.status === "healthy" || health.health?.status === "healthy");
ctx.ui.setStatus("agentmemory", lastHealthOk ? "🧠 agentmemory" : "🧠 agentmemory off");

try {
setStatus("agentmemory", lastHealthOk ? "🧠 agentmemory" : "🧠 agentmemory off");
} catch {
// UI may already be gone after session replacement; status is best-effort.
}
}

pi.registerCommand("agentmemory-status", {
Expand Down