fix(session-end): remove .unref() so process force-exits after 1500ms

[dnraitzyk]

Fixes #1069.

What

Remove .unref() from the setTimeout in session-end.mjs / session-end.ts.

Why

The session-end hook fires fire-and-forget fetch() calls to the local daemon, then does:

setTimeout(() => process.exit(0), 1500).unref();

AGENTS.md documents the intent: the process should force-exit after 1500ms so it does not block Claude Code's shutdown. But .unref() makes the timer passive — Node.js does not keep the event loop alive for an unref'd timer, but it also will not fire it while other handles (the pending fetch() calls) are keeping the loop alive.

The fetches use AbortSignal.timeout() values of 30s, 60s, and 120s. Those pending requests keep the event loop alive the entire time. Claude Code's hook deadline fires first and kills the process with:

SessionEnd hook [node "${CLAUDE_PLUGIN_ROOT}/scripts/session-end.mjs"] failed: Hook cancelled

This is intermittent because when the daemon responds fast the event loop drains before the deadline; when it is slow the race is lost.

Fix

Remove .unref(). An active timer is the only handle that keeps the event loop alive after the fetches are dispatched, so the process exits after exactly 1500ms regardless of whether the fetches have settled. This matches the documented intent and the fire-and-forget pattern AGENTS.md prescribes.

- setTimeout(() => process.exit(0), 1500).unref();
+ setTimeout(() => process.exit(0), 1500);

Summary by CodeRabbit

• Bug Fixes
  • Improved session-end handling so processes terminate reliably after the session ends.
  • Prevented lingering network requests from delaying shutdown beyond the expected timeout.

[vercel]

@dnraitzyk is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 45de2006-8654-4e63-8036-b4218b030b35

📥 Commits

Reviewing files that changed from the base of the PR and between 93ae9bc and 1ba4419.

📒 Files selected for processing (2)

• plugin/scripts/session-end.mjs
• src/hooks/session-end.ts

---

📝 Walkthrough

Walkthrough

Updated both session-end implementations to use referenced 1500ms exit timers, ensuring the process terminates after the timeout regardless of pending fetch requests. Inline comments document the event-loop behavior.

Changes

Session-end process termination

Layer / File(s)	Summary
Force session-end termination src/hooks/session-end.ts, plugin/scripts/session-end.mjs	Replaces unref’d exit timers with active 1500ms timers and documents the resulting event-loop behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

• rohitg00/agentmemory#991 — Addresses the same session-end deferred exit timer behavior.

Possibly related PRs

• rohitg00/agentmemory#688 — Implements the earlier fire-and-forget and unref’d timeout pattern in the same session-end exit logic.

Suggested reviewers: rohitg00

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing .unref() so session-end exits after 1500ms.
Linked Issues check	✅ Passed	The PR implements the linked bug fix by removing .unref() from the 1500ms session-end timer in both files.
Out of Scope Changes check	✅ Passed	The changes stay scoped to the session-end timeout behavior and related comments, with no unrelated code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}