fix: add raw provider request timeouts#413
Conversation
Signed-off-by: AjTheSpidey <aj.gupta0911@gmail.com>
|
@AjTheSpidey is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR adds configurable HTTP timeouts to LLM provider calls. A new ChangesLLM Provider HTTP Timeout Control
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
What changed
AGENTMEMORY_LLM_TIMEOUT_MSin.env.example.Why
MiniMax and OpenRouter use raw
fetchcalls. Without an abort signal, a stalled provider request can hang until the runtime/network stack gives up. This patch gives those requests the same explicit bounded-failure behavior already used elsewhere in the project.Validation
Passed locally on Windows:
npm.cmd exec -- vitest run test/provider-timeout.test.ts test/minimax-provider.test.tsnpm.cmd exec -- tsdownNot green locally:
npm.cmd testhas unrelated Windows/environment failures in existing tests, including path separator expectations, missing Python for one integration test, and timing-sensitive tests. I did not change those areas.Summary by CodeRabbit
New Features
AGENTMEMORY_LLM_TIMEOUT_MSenvironment variable (default: 120,000ms).Tests