-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(website): compare section polish #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: rohitg00/agentmemory
Length of output: 356
🏁 Script executed:
Repository: rohitg00/agentmemory
Length of output: 235
🏁 Script executed:
cat -n website/components/Compare.module.css | head -30Repository: rohitg00/agentmemory
Length of output: 875
🌐 Web query:
word-break break-word deprecated CSS modern replacement overflow-wrap💡 Result:
The CSS value word-break: break-word is deprecated and should not be used in modern web development [1][2][3]. Modern Replacement The recommended modern replacement is overflow-wrap: anywhere [4][5][6]. Why the change? 1. Deprecation: The word-break: break-word value was a non-standard, browser-specific extension that was never part of the official CSS specification [4][1]. While it remains supported in many browsers for legacy compatibility, it is officially deprecated [1][2]. 2. Functionality: The overflow-wrap property (formerly known as word-wrap) is the standard way to control how text wraps when it would otherwise overflow its container [5][7][8]. 3. overflow-wrap: anywhere vs. break-word: - overflow-wrap: break-word: This is the standard approach for most use cases. It attempts to wrap text normally and only breaks a word if it is impossible to avoid an overflow [5][7][9]. - overflow-wrap: anywhere: This is a more modern and robust option. It behaves similarly to break-word but also considers the word-breaking opportunity when calculating the minimum intrinsic size of a container, which helps prevent layout issues in flex or grid containers [5][6]. Summary of Usage - For general text wrapping: Use overflow-wrap: break-word [7][9]. - For robust layout control (especially in flex/grid): Use overflow-wrap: anywhere [4][5][6]. - Avoid: word-break: break-all (unless you specifically want to break words at any character, even when it is not necessary) and the deprecated word-break: break-word [1][7][9].
Citations:
🏁 Script executed:
Repository: rohitg00/agentmemory
Length of output: 265
🏁 Script executed:
rg -l 'stylelint' --type json --max-count 5Repository: rohitg00/agentmemory
Length of output: 82
🏁 Script executed:
Repository: rohitg00/agentmemory
Length of output: 1690
🏁 Script executed:
Repository: rohitg00/agentmemory
Length of output: 408
🌐 Web query:
stylelint rule deprecated word-break break-word CSS property💡 Result:
The CSS value word-break: break-word is deprecated [1][2]. While it remains supported in browsers for backward compatibility, it is no longer recommended for use in new projects [3][1][2]. To address this in your project: 1. Recommended Alternative: Use overflow-wrap: anywhere [4][1]. This property is the modern standard for controlling how words break when they would otherwise overflow their container [1]. 2. Stylelint Configuration: Stylelint does not have a specific built-in rule that exclusively targets the deprecation of the word-break: break-word value. However, you can manage this using the following approaches: - declaration-property-value-disallowed-list: You can explicitly disallow this specific value in your Stylelint configuration to prevent its use [5]. { "rules": { "declaration-property-value-disallowed-list": { "word-break": ["break-word"] } } } - stylelint-csstree-validator: For more comprehensive validation of CSS values against current specifications, it is recommended to use the stylelint-csstree-validator plugin [5]. This plugin can help identify deprecated or invalid values that core Stylelint rules might miss [5]. Note that the Stylelint rule property-no-deprecated is intended for deprecated CSS properties (e.g., word-wrap), not for deprecated values of valid properties [6]. Therefore, it will not flag word-break: break-word [6].
Citations:
word-break: break-wordas invalid value stylelint/stylelint#2907Replace deprecated
word-break: break-wordwithoverflow-wrap: anywhere.The
word-break: break-wordkeyword at line 21 is deprecated (non-standard, browser-specific). Since.rowis a grid container, useoverflow-wrap: anywherewithword-break: normalfor proper modern behavior.💡 Suggested patch
.row { display: grid; grid-template-columns: 1.4fr 1.3fr 1fr 1fr 1fr; gap: 16px; padding: 20px 24px; border-bottom: 1px solid var(--charcoal); align-items: center; font-size: 14px; letter-spacing: 0.12px; - word-break: break-word; + overflow-wrap: anywhere; + word-break: normal; }📝 Committable suggestion
🧰 Tools
🪛 Stylelint (17.11.0)
[error] 21-21: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)
(declaration-property-value-keyword-no-deprecated)
🤖 Prompt for AI Agents