Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow so the TypeScript VS Code extension job runs on Windows, aligning with package.json’s os: [win32] constraint and preventing npm ci from failing on Linux runners.
Changes:
- Switched the Extension (Node.js) job runner from
ubuntu-latesttowindows-latestin CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extension CI job ran on ubuntu-latest, but package.json declares os: [win32], causing npm ci to fail with EBADPLATFORM on Linux.
Fix
Changed runs-on: ubuntu-latest to runs-on: windows-latest for the Extension (Node.js) job.