Skip to content

Fix prefixing bugs for d.bs parameter default values#116

Open
TwitchBronBron wants to merge 6 commits intomasterfrom
fix-dbs-ns-prefixing
Open

Fix prefixing bugs for d.bs parameter default values#116
TwitchBronBron wants to merge 6 commits intomasterfrom
fix-dbs-ns-prefixing

Conversation

@TwitchBronBron
Copy link
Copy Markdown
Member

Fix bugs in the prefixer related to d.bs default parameters. For example, lib.d.bs:

function doSomething(cb1 = alpha.beta)
end function

Should now properly get prefixed to:

namespace logger
    function doSomething(cb1 = logger.alpha.beta)
    end function
end namespace

Also works for default values such as:

  • p1 = alpha.beta()
  • p2 = someFunc(alpha.beta())
  • p3 = alpha_beta
  • p4 = alpha_beta()

@TwitchBronBron TwitchBronBron marked this pull request as ready for review October 20, 2025 19:23
@TwitchBronBron TwitchBronBron added the create-package create a temporary npm package on every commit label Oct 20, 2025
@rokucommunity-bot
Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on 251b052. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/ropm/releases/download/v0.0.0-packages/ropm-0.11.1-fix-dbs-ns-prefixing.20251020192352.tgz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-package create a temporary npm package on every commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant