Fix g:qf_shorten_path behaviour#133
Open
newtonne wants to merge 1 commit into
Open
Conversation
The docs state that the default for `g:qf_shorten_path` is 1: https://github.com/romainl/vim-qf/blob/7e65325651ff5a0b06af8df3980d2ee54cf10e14/doc/qf.txt#L396-L398 But this isn't the case as it was defaulted to `0` in qf.vim. Additionally, I believe the intention of this call: ``` call setqflist([], 'r', qf_list_title) ``` is to clear the qflist whilst retaining the title. However, it doesn't actually clear the qflist because the first argument is ignored: ``` setqflist({list} [, {action} [, {what}]]) setqflist() Create or replace or add to the quickfix list. If the optional {what} dictionary argument is supplied, then only the items listed in {what} are set. The first {list} argument is ignored. See below for the supported items in {what}. ``` This meant that when `g:qf_shorten_path` was set to > 0, the list with shortened paths was being appended to the list with full paths, resulting in duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs state that the default for
g:qf_shorten_pathis 1:vim-qf/doc/qf.txt
Lines 396 to 398 in 7e65325
But this isn't the case as it was defaulted to
0in qf.vim.Additionally, I believe the intention of this call:
is to clear the qflist whilst retaining the title. However, it doesn't actually clear the qflist because the first argument is ignored:
This meant that when
g:qf_shorten_pathwas set to > 0, the list with shortened paths was being appended to the list with full paths, resulting in duplicates.