Add support for number ranges #602
Conversation
Improve test
cargo fmt
|
Thanks @Ztry8 for prototyping this feature! |
|
Also, this addition will need to be documented in the grammar |
|
Thank you! I've already started working about this |
Add test for deserialising inside an untagged context
|
@juntyr, is everything fine now? What should I put into |
juntyr
left a comment
There was a problem hiding this comment.
Thank you for the changes, I left some further comments
|
Thank you! l've already started to working on this |
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
|
@juntyr, I’m happy with the work we’ve done, thank you very much! I’ve implemented all of your suggestions & fixed CI. |
|
@juntyr, thanks for the corrections, I didn't notice them |
juntyr
left a comment
There was a problem hiding this comment.
We're on the home stretch now - there's also a conversation from earlier on about moving the number deserialiser that I unresolved - please have a look at that as well
|
Thanks! l've already started to working on this |
|
@juntyr, many thanks! I've improved the tests, added more clarification in the comments, and moved the number deserializer |
|
@Ztry8 Thanks, we're almost almost there - thank you so much for making all these final adjustments |
…dless of variant order
…h serializer and deserializer pub(crate)
|
@juntyr, thank you for your help and cooperation! What's left to do? |
|
@juntyr, what do you think now? |
|
@juntyr, what do you think now? |
|
@Ztry8 Thank you so much for your amazing work on this feature! I've now merged the PR. Let's give the PR a few days on main to try it out, and then I'll release a new version with the feature (feel free to ping me if I forget). |
|
@juntyr, thank you for your help and cooperation! |
This PR implements #601: support for number ranges in RON.
It's just syntactic sugar for structures with fields
start, endorstart, last.It supports both
std::opsandcore::range.Example: