Open
Conversation
In a first step, change all using declarations to the ROOT namespace, rename EColumnType -> ENTupleColumnType, and update method calls from GetSubFields() to GetMutableSubfields(). structure/feature_flag/write.C needs some additional changes because it uses the Internal API.
The only exceptions are alias declarations (to shorten type names) and structure/feature_flag/write.C, which uses the Internal API.
Since ROOT 6.36, RNTupleFileWriter::Commit() takes a compression parameter.
It is mandatory since the backport to ROOT 6.36.04.
It replaces ROOT/RNTupleUtil.hxx, which is deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a first step, change all using declarations to the
ROOTnamespace, renameEColumnType->ENTupleColumnType, and update method calls fromGetSubFields()toGetMutableSubfields(). Then replace the using declarations, and followup changes for compatibility with newer versions of ROOT.