[hist] Implement initial RProfile#22588
Conversation
It builds on RHistEngine with an additional variable.
Add, AddAtomic, Clear, Clone, Scale; implemented similarly to RHist, forwarding to RHistEngine and RHistStats.
hahnjo
added
in:Hist
test coverage
| \warning This is part of the %ROOT 7 prototype! It will change without notice. It might trigger earthquakes. | ||
| Feedback is welcome! | ||
| */ | ||
| class RProfile final { |
There was a problem hiding this comment.
Imho this should be called something more specific to histograms (RHistProfile? RProfileHist?), as "profile" is a generic term that could be overloaded (e.g. a timing profile) and since it's directly in the ROOT namespace we might want to avoid that confusion.
There was a problem hiding this comment.
hm, I think the term "profile" is well established in HEP to not be confusing in the context of a data analysis framework. For example, historically the class is called TProfile, Boost.Histogram calls it make_profile, and for YODA it's BinnedProfile / Profile1D etc.
There was a problem hiding this comment.
I'm more concerned about ambiguities in internal usage by developers than about confusion from users (RProfile might be used as an internal class in some other context). Nothing that some namespaces can't solve of course, but might be worth thinking about.
Test Results 20 files 20 suites 3d 2h 0m 23s ⏱️ Results for commit 6c4093a. |
2 participants
It builds on
RHistEnginewith an additional variable.