-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: use jinja for templating #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seblyng
wants to merge
15
commits into
ropez:master
Choose a base branch
from
seblyng:jinja
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
961c54b
feat!: use jinja for templating
seblyng a1efaf4
chore: format code with nightly cargo fmt
seblyng 9c74697
fix: remove some clippy warnings
seblyng 9bf67b9
fix: simplify the example for lists
seblyng 36e2bf3
fix: use cell instead of arc
seblyng 9fb7d7c
fix: move substitute struct into ui code
seblyng 323f36b
fix: remove dead code
seblyng 19cc9f9
fix: add back comments
seblyng de69020
fix: add custom filter for select_one and select_multiple
seblyng 132f73d
fix: make diff output smaller
seblyng 19b7fc2
fix: rename thread local variable and default to select single item
seblyng 151474c
fix: implement fallback again
seblyng 7f3dec9
fix: make diff smaller
seblyng 5315893
fix: use select_multiple for create_issue example
seblyng de9825e
fix: avoid using map when selecting multiple
seblyng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| GET {{base_url}}/repos/{{reponame}}/issues?page={{page|1}}&per_page=10 HTTP/1.1 | ||
| GET {{base_url}}/repos/{{reponame}}/issues?page={{page | fallback(1)}}&per_page=10 HTTP/1.1 | ||
| Accept: application/vnd.github+json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,3 @@ pub mod substitute; | |
| pub mod util; | ||
|
|
||
| pub mod prompt; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have something very powerful like jinja (if we merge this), and we can potentially avoid some hardcoded restrictions we have. For example, we have a requirement now for a list to be like this:
So
nameandvaluekeys.I propose that we at least keep it like this for this PR to make the scope a bit smaller, and then potentially do another breaking change if we want.
We can avoid to "map" it internally (like we do in for example the
list_option_to_stringand other places) and instead just do it like this in the template:I haven't thought about potential pitfalls with this though