Skip to content

fix: update dead documentation links#2398

Merged
christophfroehlich merged 1 commit into
ros-controls:masterfrom
Ishan1923:fix/motion-primitives-link
Jun 12, 2026
Merged

fix: update dead documentation links#2398
christophfroehlich merged 1 commit into
ros-controls:masterfrom
Ishan1923:fix/motion-primitives-link

Conversation

@Ishan1923

@Ishan1923 Ishan1923 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Updates dead documentation links causing CI 404 failures:

  • Fixes the ExecuteMotionPrimitiveSequence.action link by pointing to master (the motion_primitives branch was deleted post-merge ros-controls/control_msgs#228).
  • Updates hardcoded control.ros.org/master routes to rolling.

Related Issue

Resolves #2397

@christophfroehlich

Copy link
Copy Markdown
Member

please rebase the relevant commit on top of the master branch

@Ishan1923 Ishan1923 force-pushed the fix/motion-primitives-link branch from 1931bee to 732f237 Compare June 9, 2026 18:23

@christophfroehlich christophfroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is unrelated (but valid) cleanup in other files. please split this in two PRs

@Ishan1923

Copy link
Copy Markdown
Contributor Author

apologies; I have reset the branch to the latest upstream master and force-pushed the single commit for both link fixes.

Comment thread README.md Outdated
@Ishan1923 Ishan1923 changed the title Fix/motion primitives link fix: update dead documentation links Jun 9, 2026
@Ishan1923 Ishan1923 force-pushed the fix/motion-primitives-link branch from 732f237 to 9656705 Compare June 9, 2026 18:55
Comment thread ros2_controllers/doc/index.rst

@saikishor saikishor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still unrelated changes. Please fix

@Ishan1923 Ishan1923 force-pushed the fix/motion-primitives-link branch from 9656705 to 9a8b442 Compare June 12, 2026 13:38
@Ishan1923

Copy link
Copy Markdown
Contributor Author

this PR now strictly addresses the motion_primitives broken link.

@Ishan1923

Copy link
Copy Markdown
Contributor Author

The unrelated changes have been removed. This PR now only contains the fix for the motion_primitives broken link. The master to rolling URL updates have been moved to #2409.

@christophfroehlich christophfroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jun 12, 2026
@christophfroehlich christophfroehlich merged commit 4888dc1 into ros-controls:master Jun 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update dead master documentation links to rolling

3 participants