Trajectory replacement with full blending at message arrival time#2419
Draft
vedh1234 wants to merge 3 commits into
Draft
Trajectory replacement with full blending at message arrival time#2419vedh1234 wants to merge 3 commits into
vedh1234 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
==========================================
- Coverage 85.61% 85.30% -0.32%
==========================================
Files 148 147 -1
Lines 15837 14985 -852
Branches 1339 1277 -62
==========================================
- Hits 13559 12783 -776
+ Misses 1792 1726 -66
+ Partials 486 476 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of the legacy ROS 1 "update existing trajectory" behavior to the ROS 2
joint_trajectory_controller.Related to #84
What this PR does:
allow_trajectory_replacementparameter (default:true).ROS 1 Feature Parity Achieved in this PR:
traj_time_) rather than wall-clock time, guaranteeing zero position jumps even under speed scaling (an improvement over some legacy implementations).What this PR does NOT target (ROS 1 Parity Gaps):
Is this user-facing behaviour change?
Yes. When
allow_trajectory_replacementis true (default), publishing a future-stamped trajectory will now splice into the current motion.Did you use Generative AI?
Yes, Google Gemini and Claude were used to make improvements in manually written code, architectural analysis, and edge-case review.
Additional Information
test_execute_partial_traj_in_futurereferenced in Port over "update existing trajectory" to joint_trajectory_controller #84 has been enabled and passes.blend_no_position_jump_under_speed_scaling,blend_omitted_joint_outlasts_shorter_new_trajectory,blend_commanded_joint_follows_old_path) were added to validate the prefix/suffix math.TODOs
colcon testandpre-commit run)