feat: add sample timeout for gscam stream recovery#108
Open
KirillHit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gscamcan hang indefinitely when a stream temporarily stops producing samples, soreopen_on_eofmay never get a chance to reopen the pipeline. This was observed with looped RTSP streams that periodically restart.Cause
gscamwaits for frames withgst_app_sink_pull_sample(), which can block indefinitely if the RTSP pipeline stays alive but no new samples arrive. In that state,reopen_on_eofdoes not get a chance to reopen the stream.Solution
Add an optional
sample_timeout_msparameter. When set, gscam usesgst_app_sink_try_pull_sample()with that timeout. If no sample is received, the loop exits and the existingreopen_on_eoflogic restarts the stream. Default is 0, preserving the previous blocking behavior.