Skip to content

Ros2cli diagnostics tool#328

Draft
russkel wants to merge 26 commits intoros:ros2from
russkel:ros2cli_diagnostics
Draft

Ros2cli diagnostics tool#328
russkel wants to merge 26 commits intoros:ros2from
russkel:ros2cli_diagnostics

Conversation

@russkel
Copy link

@russkel russkel commented Jan 21, 2024 •
edited
Loading

Adds a ros2 CLI tool:

TODO

  • rename to ros2diagnostics to follow convention
  • as per your suggestion change verbs to list/echo.
  • convert csv to an output format option on echo: ros2 diagnostics echo -f csv > my-csv.csv (unix philosophy)
    • add yaml/json output
  • refactor DiagnosticsParser into a generator with a WaitSet and remove mode
  • add self test verb
  • add tests

Replaces #301

robo and others added 26 commits October 7, 2023 11:11
@russkel
ros2diagnostics cli init
e7fff46
@russkel
rename hello to diagnostics
3391fee
@russkel
add option with string
6e12234 
csv --output
@russkel
arg parse examples
8a112d8
@russkel
add csv verb
1aed29a
@russkel
version 0.0.1
e2e917e
@robobe @ct2034 @russkel
Update ros2diagnostics_cli/package.xml
9a22aec 
Co-authored-by: Christian Henkel <6976069+ct2034@users.noreply.github.com>
@russkel
clean test and scripts file
f637fad
@russkel
add copyright
c13ce4e
@russkel
fix: support python 3.8 remove match
c4d5f29
@russkel
format and run linters
1c3ca74
@russkel
fix: suport python 3.8
e03df55 
remove math case
remove some of pylint warnings
@russkel
fix flake8 errors
6c2b60c
@russkel
fix: handle name without clone task name separator
f662b6c
@russkel
fix: extract node name
35aa3a4 
todo: add regex for extract node name from diagnostic name
@russkel
set version and license
85360cd
@russkel
init tutorials
6f1b85f
@russkel
remove diagnostic_tutorial from PR
afe944e
@ct2034 @russkel
gh tests for the new package
249b2db 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @russkel
fixing flake8 errors
3d43229 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @russkel
fixing pep257 errors
ccd80a2 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@russkel
fix: address suggestions
8112093
@russkel
fix: remove _cli suffix
2dd80c0
@russkel
wip
38ab78b
@russkel
fix: list, show work
f9cb48c
@russkel
fix: rename show to echo
3935bf6
@russkel russkel marked this pull request as draft January 21, 2024 06:12
@ct2034 ct2034 added enhancement This tackles a new feature of the code (and not a bug) ros2 PR tackling a ROS2 branch needs more work Someone has worked on this but more work is needed labels Jan 25, 2024
@nnarain
Copy link

nnarain commented Jun 20, 2024

Hey @russkel

This is something I'm interested in, any plans to complete the work here?

@russkel
Copy link
Author

russkel commented Jun 25, 2024 •
edited
Loading

Hey @russkel

This is something I'm interested in, any plans to complete the work here?

Hello @nnarain, it absolutely is. Other priorities have prevented me from moving on this further. Hopefully some time will free up soonish. What particular part were you interested?

@nnarain
Copy link

nnarain commented Jun 26, 2024

At my company we are making the slow migration to ROS 2. Tools like this are a nice QoL during development and a lot of people are used to using rosdiagnostic command (we actually use the output for the ssh login text). Not something I can't do without for now, but definitively a nice to have. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement This tackles a new feature of the code (and not a bug) needs more work Someone has worked on this but more work is needed ros2 PR tackling a ROS2 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@russkel @nnarain @ct2034 @robobe