Stop flooding the terminal by default with all matches, switch to debug if desired

[MCFurry]

We noticed that when extending a ROS system with many analyzers, the terminal during startup is flooded with all the analyzer matches.
I reckon these can be debug logs that one can enable when desired.

(Example in the tests, since these require these stdout logs)

[Timple]

The following tests FAILED:
	  2 - ntp_monitor_launchtest (Failed)

This monitor was not modified in this PR. I'll rebase to see if that helps.

[Timple]

Ping @ct2034 Any objections here?

[Timple]

Or can this at least get in before Kilted? 🙂
It's coming up! https://discourse.ros.org/t/upcoming-ros-2-feature-freeze-for-kilted-kaiju-on-april-14th/43096/2

[ct2034]

Can we please keep those messages that are not triggered per match on info

[ct2034]

Hey @MCFurry @Timple
Thanks for the contribution.
I am a little reluctant against changing the logging level in the code, because that is something that can be done depending on the runtime.
But I agree that it is generally a good idea to not have messages that are emitted repeatedly (like per match) in info.
So, I am asking you to please change all those messages that are emitted only once per initialization back to info.

[Timple]

Sorry it took a while!

[ct2034]

Based on what we discussed above, that I am happy to change the level in the match method. I would therefore expect no changes in the init method of diagnostic_aggregator/src/analyzer_group.cpp. Or are there any reasons to also change those tha I am missing right now?

In any case, I think this would also be a good use for RCLCPP_DEBUG_THROTTLE. What do you think?

[Timple]

The issue is that there a loop around all parameters:

for (const auto & param : parameters) {

Every analyzer added prints information about all other analyzers as well. Since we have a lot of analyzers, adding only 1 causes a massive print flood.

[Timple]

@ct2034 if you like things to be verbose, do you have any ideas how to get around printing always all parameters?