Open
Conversation
Timple
force-pushed
the
feature/report-stale-if-one-stale
branch
from
f9b78c0 to
8cd4d07
Compare
Contributor
Author
|
Rebased as build failed on #507 |
ct2034
added
the
enhancement
Contributor
Author
|
Any objections here? We think it makes more sense to report STALE as summary. Because now you can have an ERROR without any actual ERROR states. |
Contributor
Author
|
If there are any reasons not to do this, we'd also like to hear. Or should this pass an MPC or something? |
Timple
force-pushed
the
feature/report-stale-if-one-stale
branch
from
8cd4d07 to
601b4a6
Compare
Contributor
Author
|
Almost a year... Can someone point us at someone who can shine a light if this is desired or undesired? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going from:
to:
As a bonus, the message that caused the degradation of the diagnostics is added to the toplevel state. This is useful for reporting mechanisms such as error logs.