Undefine ERROR macro when build on Windows#545
Closed
Conversation
* Undef ERROR to build on Windows Signed-off-by: Felix F Xu <felixfxu@gmail.com> * Undef ERROR to build on Windows Signed-off-by: Felix F Xu <felixfxu@gmail.com> * Revert ERROR usage --------- Signed-off-by: Felix F Xu <felixfxu@gmail.com>
ct2034
requested changes
Dec 2, 2025
Collaborator
ct2034
left a comment
ct2034
left a comment
There was a problem hiding this comment.
- Please open an issue and clearly describe the issue you are having. Including your OS version and all necessary steps
- I will close this PR, because Error messages are an integral part of every ROS package and it builds in the CI as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefine ERROR macro to build on Windows