You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lyrical is about to be released, the rostooling/setup-ros-docker:ubuntu-resolute-ros-lyrical-ros-base-latest docker image already exists. I successfully ran the ../generate_bindings.py rcl_wrapper.h lyrical . command and ran the subscriber example on lyrical.
Hi, thanks for the work on adding Lyrical support.
While testing this PR, I noticed that it currently fails to compile because rclrs/src/rcl_bindings_generated_lyrical.rs appears to be missing from the changeset.
The PR updates rcl_bindings.rs to include the generated Lyrical bindings file, but the generated file itself does not seem to be committed. As a result, a fresh checkout of the branch fails to build with a missing file error.
Could you please verify whether rcl_bindings_generated_lyrical.rs was accidentally omitted from the PR and push it if necessary?
@ottojo thanks for submitting this PR. Could you please rebase on top of main? I've merged a series of fixes that should make this PR pass. Also, as @xiaoyang20010608 mentioned, the bindings file for lyrical is missing, could you add it as well? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lyrical is about to be released, the
rostooling/setup-ros-docker:ubuntu-resolute-ros-lyrical-ros-base-latestdocker image already exists. I successfully ran the../generate_bindings.py rcl_wrapper.h lyrical .command and ran the subscriber example on lyrical.