feat(rclrs): add Clock sleep and async sleep APIs#647
Open
PvRao-29 wants to merge 1 commit into
Open
Conversation
Add sleep_for, sleep_until, async_sleep_for, and async_sleep_until to Clock, aligned with rclcpp semantics. Async variants yield to the runtime so they work under use_sim_time without blocking the executor. Fixes ros2-rust#604
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clock::sleep_for,sleep_until,async_sleep_for, andasync_sleep_until, aligned with rclcpp semanticsros_time_is_active()helper used by the sleep loopuse_sim_timewithout blocking the executorFixes Add support for Clock sleep_for/sleep_until #604
Design notes
sleep_forcan still deadlock under sim time in a single-threaded executor callback; documented in rustdoc, with async variants as the recommended pathboollike rclcpp (true= target reached,false= context invalid)Test plan
cargo fmtcargo clippy --all-targets(pre-existing warnings only)cargo test clock— 13 passed including 4 new clock sleep tests