Fix macOS compile: add __ELF__ check for .note.GNU-stack#28
Merged
clalancette merged 1 commit intoros2:ros2from Nov 3, 2023
PhDittmann:ros2
Merged
Fix macOS compile: add __ELF__ check for .note.GNU-stack#28clalancette merged 1 commit intoros2:ros2from PhDittmann:ros2
clalancette merged 1 commit intoros2:ros2from
PhDittmann:ros2
Conversation
Signed-off-by: Philipp Dittmann <dittmann@cs.uni-bremen.de>
PhDittmann
referenced
this pull request
Oct 13, 2023
Newer versions of binutils (2.39 and above) complain if you have assembly without explicitly marking that it is not using an executable stack (see https://www.redhat.com/en/blog/linkers-warnings-about-executable-stacks-and-segments for more details). Mark it here to quiet that warning. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Nov 2, 2023
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Thanks! I'll run CI on this and see how it goes.
|
CI:
|
|
This would be good to go upstream into Snaipe#38 as well. |
Good call. Done in Snaipe@77dd9e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix macOS build #27.
.section .note.GNU-stack, "", @progbits, to make the stack not executable, is not compatible with Apple. The common way I found is checking for__ELF__.