Compile fix for upcomming changes to rclcpp::Executor#668
Merged
Conversation
fujitatomoya
approved these changes
Apr 5, 2024
fujitatomoya
left a comment
fujitatomoya
left a comment
Contributor
There was a problem hiding this comment.
lgtm with green CI. (thanks for the refactoring.)
Contributor
Author
|
@fujitatomoya can we merge this ? We don't need to merge 2382 prior to this. |
Contributor
Sure, let me launch CI |
ahcorde
approved these changes
Apr 9, 2024
ahcorde
left a comment
ahcorde
left a comment
Contributor
There was a problem hiding this comment.
- Linux
- Linux-aarch64
- Windows
ahcorde
requested changes
Apr 9, 2024
ahcorde
left a comment
ahcorde
left a comment
Contributor
There was a problem hiding this comment.
Do you mind to check the new warnings?
Contributor
Author
|
I'll look into it tomorrow. |
added 2 commits
April 10, 2024 10:52
This fixes a compile error, for the addition of a second spin method to the executor. Signed-off-by: Janosch Machowinski <j.machowinski@nospam.org>
Signed-off-by: Janosch Machowinski <j.machowinski@nospam.org>
Contributor
Author
|
@ahcorde fixed |
Contributor
|
ahcorde
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be merge before ros2/rclcpp#2382