Fix Pytest 8/9 compatibility in hooks#972
Merged
Merged
Conversation
mjcarroll
force-pushed
the
fix/pytest-compatibility
branch
2 times, most recently
from
66af3cc to
d86b699
Compare
Member
Author
|
Pulls: #972
|
This commit addresses two issues: 1. Renames deprecated path argument to module_path/collection_path in pytest hooks to support Pytest 8/9. 2. Ensures LaunchService run_async task is always awaited by registering the finalizer earlier and passing the task explicitly. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
mjcarroll
force-pushed
the
fix/pytest-compatibility
branch
from
d86b699 to
6d7358b
Compare
Member
Author
|
Pulls: #972, ros2/launch_ros#540
|
ahcorde
approved these changes
May 5, 2026
Contributor
|
https://github.com/Mergifyio backport lyrical |
✅ Backports have been createdDetails
|
This was referenced May 5, 2026
mjcarroll
added a commit
to mjcarroll/launch
that referenced
this pull request
May 7, 2026
…s2#972) This commit addresses two issues: 1. Renames deprecated path argument to module_path/collection_path in pytest hooks to support Pytest 8/9. 2. Ensures LaunchService run_async task is always awaited by registering the finalizer earlier and passing the task explicitly. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
clalancette
added a commit
that referenced
this pull request
May 8, 2026
* Fix Pytest 8/9 compatibility and coroutine leaks in launch_pytest (#972) This commit addresses two issues: 1. Renames deprecated path argument to module_path/collection_path in pytest hooks to support Pytest 8/9. 2. Ensures LaunchService run_async task is always awaited by registering the finalizer earlier and passing the task explicitly. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> (cherry picked from commit 0630831) * Robust pytest_ignore_collect for multi-version Pytest compatibility (#974) * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * More fixes (hopefully working this time). Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Owen-Liuyuxuan
pushed a commit
to tier4/launch
that referenced
this pull request
Jun 11, 2026
* fix regressions (ros2#959) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix test_io_tests for Ubuntu26 (ros2#960) * fix test_io_tests Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix other test case Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Correct typos (ros2#961) Signed-off-by: augustelalande <auguste.lalande@gmail.com> * Changelog Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * 3.9.7 * Fix Pytest 8/9 compatibility and coroutine leaks in launch_pytest (ros2#972) This commit addresses two issues: 1. Renames deprecated path argument to module_path/collection_path in pytest hooks to support Pytest 8/9. 2. Ensures LaunchService run_async task is always awaited by registering the finalizer earlier and passing the task explicitly. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * Robust pytest_ignore_collect for multi-version Pytest compatibility (ros2#974) * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * More fixes (hopefully working this time). Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> * changelogs Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> * 3.10.0 --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> Signed-off-by: augustelalande <auguste.lalande@gmail.com> Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> Co-authored-by: Michael Carlstrom <rmc@carlstrom.com> Co-authored-by: Auguste Lalande <auguste.lalande@gmail.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecated hook signatures in launch and launch_testing that cause failures in newer pytest versions (e.g. Pytest 9.0).