Update page on custom interfaces#6312
Conversation
Updated the article "Implementing custom interfaces - how to" as approved by Geoff and 3di.
|
You have some liner errors to address. |
fujitatomoya
left a comment
There was a problem hiding this comment.
a couple of minor comments. thanks for making contribution.
kscottz
left a comment
There was a problem hiding this comment.
This is good and is pretty close to ready to go.
I would like to find a way to address my comment on line 32. I think an area where new users struggle is figuring out when and where to create a new message type. A lot of thought goes into our standard messages and I would hope that the our users put the same amount of care into creating their own message types. Migrating and updating in messages in ROS is a huge pain, and we really want users to be thoughtful about constructing their messages initially.
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Signed-off-by: Tully Foote <tully.foote@gmail.com>
|
@kscottz Hi Kat, pinging you again on this one. This has been gathering dust for a while, so yesterday I merged in rolling plus made a tiny update, something I missed the previous time. Anyway, now CI is failing due to some unresolved rosdistro refs and unreachable intersphinx inventories. Not my doing obviously, came from upstream, but let me know if I should do anything about it. Thanks. |
|
Thanks for the friendly ping. I'll need to see what's going on with the docs CI before we merge this. Unclear when the current issue was introduced. We may need you to do one quick rebase. |
Updated the article "Implementing custom interfaces - how to" as approved by Geoff and 3di.
Description
Related to: ros2/ros2#1725
Updated the custom interfaces how-to page by replacing the old single-package tutorial with the new revised tutorial, and updated the TOC to add the new page entry and remove/replace the old one (incl. the Beginner-Client-Libraries tutorial list).
Did you use Generative AI?
No.
Additional Information
Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.