Allow read empty socket in nonblocking mode on win32#79
Open
arha wants to merge 4 commits intorossengeorgiev:masterfrom
Open
Allow read empty socket in nonblocking mode on win32#79arha wants to merge 4 commits intorossengeorgiev:masterfrom
arha wants to merge 4 commits intorossengeorgiev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I do development on windows but prod goes on *nix.
This is a small improvement on 8674bbd which should allow non-blocking sockets to not spam errors on win32 systems, as originally described by in issue 57.
Thanks for the lib, 73.