Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Summary
EpisodesPanelfocus containment by default, and only allows focus to leave the panel while an episode context menu is open.EpisodesPanelcall sites found by search: details seasons list and player settings episodes list.Compliance Review
Passed. Rule sources checked: root
AGENTS.md,.kent/commands/compliance-review.md,.kent/project-contract.md, PUB-2 task body, and.todo/bugfix-season-context-menu-focus/diagnosis.md. Reviewed diff contains only:app/src/main/java/com/kino/puber/ui/feature/player/component/EpisodesPanel.ktapp/src/main/java/com/kino/puber/ui/feature/details/component/DetailsScreenContent.ktapp/src/main/java/com/kino/puber/ui/feature/player/component/PlayerSettingsPanels.ktNo compliance findings were reported.
Verification
./tools/agentw :app:compileDevDebugKotlin- passed (BUILD SUCCESSFUL, configuration cache reused)..todo/bugfix-season-context-menu-focus/: menu focus lands on the context-menu action, DPAD down moves within the menu, dismissal returns focus to the episode card, and normal no-menu left containment remains active.rg "EpisodesPanel\\(" app/src/main/java/com/kino/puber/ui/featureconfirmed both production call sites were updated.Skipped Checks / Blockers
.kent/commands/ship-pr.mdwas missing in this PUB-2 worktree. For shipping procedure, I followed the project contract and the equivalent command file present in sibling Puber worktrees.