[feat] support cancel job.#16
Open
fakeyanss wants to merge 4 commits into
Open
Conversation
Defines JobWithCancel interface. Require a unique string as jobID in every job.
When add or cancel a job cost much time(more than schedule accuracy), jobs in entries will not execete in next one period. To fix this problem, update the time variable 'now' after adding or canceling a job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines JobWithCancel interface. Require a unique string as jobID in each job.
Sometimes we need to cancel job after it's lifecycle finished. For example, start a monitoring job while a tcp socket alive, and cancel the monitoring job after socket closed.
So I develop the feature, support cancel job. And I defined a
JobWithCancelinterface, aJobID()function to index job when cancel it.Just see this samle:
lastly, I using go mod in this project. I think it is compatible in higher version of golang. If you think module is not necessary, I could remove it.