fix(e2e): probe /handshake for readiness instead of removed /servers#61
Merged
Conversation
The e2e task waited on GET /servers, which was removed from the peer-facing app, so curl -sf looped on a 404 until the 60s timeout fired (exit 124), failing the e2e job even though Jack was up. Probe the authenticated /handshake endpoint, which still exists.
The peer-facing app now returns opaque error bodies, so a wrong api key yields a generic 'Unauthorized' description, not 'Unauthorized: invalid API key'. Update the e2e assertion to match (and assert the detail is absent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e readiness wait in
.mise/tasks/test/e2epolledGET /servers, which was removed from the peer-facing app in the security hardening.curl -sflooped on the 404 until the 60stimeoutfired (exit 124), failing thee2ejob even though both Jack instances were up and healthy.Switches the probe to the authenticated
/handshakeendpoint (still present on the peer-facing app), keeping the existing API-key header.Notes
testjob and the shipped image are unaffected; this just unblocks thee2ejob./pingin the security change; this is the separate task-script probe.Greptile Summary
This PR fixes the e2e readiness check after the peer-facing route changes. The main changes are:
/handshakeinstead of the removed/serversroute in the e2e task.Confidence Score: 5/5
This looks safe to merge.
Reviews (3): Last reviewed commit: "chore: remove .cursor editor rules" | Re-trigger Greptile
Context used (5)