Open
Conversation
Certificates with * in their filenames are not handled by dataplane API. So if we encounter a cert like that, then a new cert is uploaded with _ instead of *, but the old cert has to be deleted manually before haproxy will start using it. Added integration tests to cover all scenarios including this * -> _ one.
Code Coverage ReportTotal Coverage: Coverage by function |
certificatee checks the dataplane API to determine if a new certificate is available to be installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificates with * in their filenames are not handled by dataplane API v2 correctly.
The old code assumed that normalizing the URL works, but dataplane doesn't do anything and doesn't error out.
Now if we encounter a cert like that, a new cert is uploaded with _ instead of *.
The old cert has to be manually deleted (rundeck job?) before haproxy starts using it.
This step is super important because haproxy is configured to serve ssl certs from a dir
and * beats _ in precedence, so the old cert will continue to be served until it is removed.
Added integration tests to cover all scenarios including this * -> _ one.