Open
Conversation
par.pl updates are to keep things in synch, but this code seems not to be exercised for pp packed exe files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default pp unpack directory under Windows to be in the user's %LOCALAPPDATA% directory, following discussions in and around https://rt.cpan.org/Public/Bug/Display.html?id=132811#txn-1902197
The system could alternately unpack under
%LOCALAPPDATA%/Programs. This seems to be where some other programs are installed locally (Python and MS VS Code in my case) so might be easier to find.I also wonder if the top directory could include the exe name to make it easier to identify, e.g. for later removal.