Goerli migration by joaoiovlabs · Pull Request #348 · rsksmart/tokenbridge

joaoiovlabs · 2022-09-13T18:52:58Z

No description provided.

gsoares85 · 2022-09-13T20:13:59Z

bridge/hardhat.config.js

-      },
-      tags: ['prod'],
-    },
+    // JUST TO AVOID MISTAKES


I think you can remove this commented code

gsoares85 · 2022-09-13T20:14:08Z

bridge/hardhat.config.js

-      },
-      tags: ['prod'],
-    },
+    // JUST TO AVOID MISTAKES


Same as above

gsoares85 · 2022-09-13T20:14:27Z

bridge/hardhat.config.js

  multiSigAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138';
  multiSigAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x88f6b2bc66f4c31a3669b9b1359524abf79cfc4a';
-  multiSigAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138';
+  multiSigAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138'; // TODO: SHOULD BE UPDATED


This TODO is done?

gsoares85 · 2022-09-13T20:14:35Z

bridge/hardhat.config.js

  wrappedCurrencyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x967f8799af07df1534d48a95a5c9febe92c53ae0';
  wrappedCurrencyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x09b6ca5e4496238a1f176aea6bb607db96c2286e';
-  wrappedCurrencyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xd0A1E359811322d97991E03f863a0C30C2cF029C';
+  wrappedCurrencyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xd0A1E359811322d97991E03f863a0C30C2cF029C'; // TODO: SHOULD BE UPDATED


gsoares85 · 2022-09-13T20:14:41Z

bridge/hardhat.config.js

  proxyAdminAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d';
  proxyAdminAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x8c35e166d2dea7a8a28aaea11ad7933cdae4b0ab';
-  proxyAdminAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xe4d351911a6d599f91a3db1843e2ecb0f851e7e6';
+  proxyAdminAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xe4d351911a6d599f91a3db1843e2ecb0f851e7e6'; // TODO: SHOULD BE UPDATED


gsoares85 · 2022-09-13T20:14:49Z

bridge/hardhat.config.js

  allowTokensProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0xcb789036894a83a008a2aa5b3c2dde41d0605a9a';
  allowTokensProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0xc65bf0ae75dc1a5fc9e6f4215125692a548c773a';
-  allowTokensProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x92bf86334583909b60f9b798a9dd7debd899fec4';
+  allowTokensProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x92bf86334583909b60f9b798a9dd7debd899fec4'; // TODO: SHOULD BE UPDATED


gsoares85 · 2022-09-13T20:14:55Z

bridge/hardhat.config.js

  bridgeProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x9d11937e2179dc5270aa86a3f8143232d6da0e69';
  bridgeProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x684a8a976635fb7ad74a0134ace990a6a0fcce84';
-  bridgeProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d';
+  bridgeProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d'; // TODO: SHOULD BE UPDATED


gsoares85 · 2022-09-13T20:15:03Z

bridge/hardhat.config.js

  federationProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x7ecfda6072942577d36f939ad528b366b020004b';
  federationProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x5d663981d930e8ec108280b9d80885658148ab0f';
-  federationProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xa347438bc288f56cb6083a79133e70dd2d1f6c2d';
+  federationProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xa347438bc288f56cb6083a79133e70dd2d1f6c2d'; // TODO: SHOULD BE UPDATED


gsoares85 · 2022-09-13T20:15:10Z

bridge/hardhat.config.js

  sideTokenFactoryAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x44fcd0854d745efdef4cfe9868efe4d4eb51ecd6';
  sideTokenFactoryAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x08C191A7B5Edaa59853705F7eaE95E3E4238D73e';
-  sideTokenFactoryAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x984192ad76A8FFF2edf39C260324d32d8A80512b';
+  sideTokenFactoryAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x984192ad76A8FFF2edf39C260324d32d8A80512b'; // TODO: SHOULD BE UPDATED


coveralls · 2022-09-26T21:23:30Z

Coverage remained the same at 96.862% when pulling dccafd5 on draft-goerli-migration into 297ed54 on master.

lgtm-com · 2022-09-27T22:00:49Z

This pull request introduces 1 alert when merging 66cc472 into 297ed54 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

sonarqubecloud · 2022-09-28T23:40:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.9% Duplication

lgtm-com · 2022-09-28T23:43:51Z

This pull request introduces 2 alerts when merging dccafd5 into 297ed54 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

gsoares85 · 2022-09-29T19:35:53Z

bridge/deploy/05_deploy_bridgeProxy.js

  ];

-  const deployProxyResult = await deploy('BridgeProxy', {
+  const deployResult = await deploy('BridgeProxy', {


Let the name deployProxyResult because we are deploying a proxy contract in here

gsoares85 · 2022-09-29T19:39:42Z

federator/src/contracts/IAllowTokensV0.ts

-    if (this.chainId === 31 || this.chainId === 42) {
-      // rsk testnet and kovan
+    if (this.chainId === 31 || this.chainId === 5) {
+      // rsk testnet and goerli TO DO: ASK AUGUSTO ABOUT CONFIRMATIONS.


I think we can leave the number of confirmations as it is and remove this comment

sonarqubecloud · 2023-07-31T12:18:20Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
1 Security Hotspot
4 Code Smells

No Coverage information
5.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud · 2024-07-05T12:37:10Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarCloud

Goerli migration

3f81283

joaoiovlabs requested a review from augustoIOV September 13, 2022 18:52

gsoares85 reviewed Sep 13, 2022

View reviewed changes

joaoiovlabs added 5 commits September 14, 2022 16:49

Goerli migration

23c0e51

Bridge deploy

c6bb25d

change goerly to goerli

80175ef

change goerly to goerli

711b1fc

change goerly to goerli

1bbda46

joaoiovlabs added 2 commits September 27, 2022 18:48

update scripts

c0088a6

rename file

fae136b

setup the original token in rsk bridge and add sidetoken in the bridge.

7b3e2b8

gsoares85 reviewed Sep 29, 2022

View reviewed changes

snyk-bot mentioned this pull request Oct 12, 2022

[Snyk] Upgrade hardhat-deploy from 0.9.24 to 0.11.15 agentjacker/tokenbridge#1

Open

Luisfc68 force-pushed the draft-goerli-migration branch from dccafd5 to 810ebde Compare July 7, 2023 12:36

Luisfc68 force-pushed the draft-goerli-migration branch from 810ebde to b05402d Compare July 31, 2023 12:16

Luisfc68 force-pushed the master branch from 716dad0 to 3fcefc0 Compare July 31, 2023 12:27

gsoares85 force-pushed the draft-goerli-migration branch from b05402d to 7b3e2b8 Compare July 5, 2024 12:35

gsoares85 force-pushed the master branch from d7c6ee8 to b97de2d Compare August 22, 2024 13:37

Conversation

joaoiovlabs commented Sep 13, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Sep 27, 2022

Uh oh!

sonarqubecloud bot commented Sep 28, 2022

Uh oh!

lgtm-com bot commented Sep 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 31, 2023

Uh oh!

sonarqubecloud bot commented Jul 5, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coveralls commented Sep 26, 2022 •

edited

Loading