fix: correctly handle scope packages on win32 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
force-pushed
the
win32
branch
2 times, most recently
from
72c2204 to
3d3f345
Compare
Member
Author
|
@chenjiahan PTAL 👋 |
chenjiahan
reviewed
Nov 18, 2025
|
|
||
| run(); | ||
| const require = createRequire(import.meta.url); | ||
| const pkg = require('./package.json'); |
Member
Author
There was a problem hiding this comment.
that means we need to either use import attributes (node 20 required, not friendly to node 18 users), or a build process to replace the version from bin. 🤔 i think require is somehow acceptable here.
chenjiahan
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only one line change https://github.com/rspack-contrib/prebundle/pull/43/files#diff-a09b7f67f5f992f7ef9d9299f6fac774fb218572c9c2960eb2c30293067a8843L12, others are tests.
this PR is to avoid error like https://github.com/rspack-contrib/prebundle/actions/runs/19458939277/job/55678426195?pr=43#step:6:41