Skip to content

perf(concat_source): skip Mutex acquire in add() under &mut self #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSerFeng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(concat_source): skip Mutex acquire in add() under &mut self #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82da852
perf(concat_source): skip Mutex acquire in add() under &mut self
JSerFeng Apr 23, 2026
9c6efe2
Merge branch 'main' into fy/jolly-mendeleev-0b5e28
JSerFeng Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/concat_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,14 @@ impl ConcatSource {

/// Add a [Source] to concat.
pub fn add<S: Source + 'static>(&mut self, source: S) {
let children = &mut *self.children.lock().unwrap();
// `&mut self` guarantees exclusive access, so the Mutex doesn't need to be
// locked here — `get_mut` skips the atomic acquire/release. This matters
// because `add` is called many hundreds of times per chunk in rspack's
// code-generation hot path.
let children = self
.children
.get_mut()
.expect("ConcatSource children mutex poisoned");

if let Some(optimized_children) = self.is_optimized.take() {
*children = optimized_children;
Expand Down
Loading