Addition of flexible body.content container#78
Open
TenaciousB12 wants to merge 4 commits intorstaib:masterfrom
Open
Addition of flexible body.content container#78TenaciousB12 wants to merge 4 commits intorstaib:masterfrom
TenaciousB12 wants to merge 4 commits intorstaib:masterfrom
Conversation
added 4 commits
July 18, 2014 08:18
The current body.content container has a fixed height (set by min-height in CSS). Changes implemented in CSS and the steps.js file to set the height of the container based on the content inside, and set the min-height style when using a vertical step layout to prevent the container from becoming smaller/shorter than the steps.
The current body.content container has a fixed height (set by min-height in CSS). Changes implemented in CSS and the steps.js file to set the height of the container based on the content inside, and set the min-height style when using a vertical step layout to prevent the container from becoming smaller/shorter than the steps.
Change to the vertical page to demo the container flexibility.
Previous commit used a hard-coded animation speed value for the container resizing. This one properly utilizes the existing transitionEffectSpeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 files changed to create a flexible wizard body container (JS, CSS and one demo html file) that will adjust height based on the content provided. Please review and modify to suit if not accepting the pull request outright. I only commented out the CSS as someone may want to still utilize a fixed min-height container when using the horizontal steps layout, however it is not necessary.