chore: remove superassignment operator and nolint#758
Merged
Conversation
Add direct test coverage to prove compatibility.
Discovered while auditing .packrat_mutables references. As of 3c87034, the state lived directly on the `.packrat` environment. With 5108287, the state moved into a `new_defaults()` object, `.packrat_mutables`, which requires `$get("field")`. With cd77393, the `.packrat_mutables$origLibPaths` reference was added, mixing the old and NEW styles. The `.packrat_mutables$origLibPaths` has always resolved to `NULL` and was likely not noticed because `origLibPaths` frequently contains overlapping entries. Includes a test confirming the use of origLibPaths.
aronatkins
force-pushed
the
aron-no-nolint
branch
from
July 17, 2026 19:09
bcbf5cd to
b08bb13
Compare
karawoo
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added direct test coverage to prove compatibility.
Additionally, fix an
origLibPathslookup.Discovered while auditing .packrat_mutables references.
As of 3c87034, the state lived directly on the
.packratenvironment.With 5108287, the state moved into a
new_defaults()object,.packrat_mutables, which requires$get("field").With cd77393, the
.packrat_mutables$origLibPathsreference was added, mixing the old and NEW styles.The
.packrat_mutables$origLibPathshas always resolved toNULLand was likely not noticed becauseorigLibPathsfrequently contains overlapping entries.