Explain unexpected work recursion before logging fatally#289
Merged
Conversation
The unmarked-recursion message named only the work type, so a process killed by FatalRecurseCheck gave no hint of why it exited or where the recursion came from. State the cause and the fix (mark the context with ContextWithExpectedRecursion) in both log paths, and include the stack in the fatal path to locate the unmarked call chain.
glin
requested review from
a team,
CDRayn and
jstruzik
and removed request for
a team
July 16, 2026 23:40
nodivbyzero
approved these changes
Jul 17, 2026
jstruzik
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while debugging a downstream product that exited with only
Work with type 64 attempted recursion without being marked for recursion. The message names the work type but not why the process died or where the recursion came from, so locating the unmarked runner took an investigation that a stack trace would have answered immediately.Changes in
OptionallyRecurse:ContextWithExpectedRecursion, and the runner should mark its context.FatalRecurseCheckbeing enabled and includesdebug.Stack()to locate the unmarked call chain.r.Recurseas before.Testing:
go test ./pkg/rsqueue/queue/passes. Log-output change only.