prompt before removing packages from non-project libraries#2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2331.
Changes
renv::remove()gains apromptargument (defaultinteractive()), and now asks for confirmation before removing packages from a library other than the project library -- for example, when called without an activated renv project, where the target library would be the user library. No prompt is shown when removing from the project library itself.NULL, e.g.renv::record(list(dplyr = NULL)), with cross-references betweenremove()andrecord()clarifying that the former modifies only the library and the latter only the lockfile.Tests
test-remove.Rcovering removal from the project library, prompt accept/decline behavior for non-project libraries, and that no prompt is shown for the project library.devtools::test(filter = "remove|record"): 54 passed.