Fix copy and clean-up problems on immutable OS#156
Open
eline-anslot wants to merge 2 commits intorstudio:mainfrom
Open
Fix copy and clean-up problems on immutable OS#156eline-anslot wants to merge 2 commits intorstudio:mainfrom
eline-anslot wants to merge 2 commits intorstudio:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sasslibrary create problems when used on an immutable system like NixOS, see GitHub issue for more context. The same problem has been solved inofficerpackage in an identical manner.I do not think it is possible to add unit tests in the tests/testthat directory. Note that the style guideline returns a 404 error.
Run
devtools::check()(or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.Add an entry to NEWS.md concisely describing what was changed.