Add 313-card-tab-focus#178
Merged
Merged
Conversation
gadenbuie
marked this pull request as ready for review
May 18, 2023 17:12
#Conflicts: # inst/apps/sysinfo-mac-4.1.txt # inst/apps/sysinfo-mac-4.3.txt # inst/apps/sysinfo-win-3.6.txt # inst/apps/sysinfo-win-4.0.txt # inst/apps/sysinfo-win-4.1.txt # inst/apps/sysinfo-win-4.2.txt # inst/apps/sysinfo-win-4.3.txt
schloerke
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The primary goal of this PR is to test rstudio/bslib#557. The app contains three full-screen expandable cards. The first has no focusable elements, the second has many input plus two child cards, and the third includes a plotly plot.
The test cycle exercise the behavior around entering and exiting full screen mode as well as the management of tab focus while in the full screen card.
Demo
Here's a short video walking through the app
Screenshare.-.2023-05-17.2_33_20.PM.mp4
Todo