fix: mutate the same variable in place

[wreckage0907]

Description

• Updated the logic to handle Select field options by supporting options provided as a string (split by newline), list, tuple, or a single value, ensuring consistent formatting and preventing errors from unexpected types. (next_crm/ncrm/doctype/crm_fields_layout/crm_fields_layout.py, next_crm/ncrm/doctype/crm_fields_layout/crm_fields_layout.pyL39-R55)

• A latent Next CRM bug was mutating shared Frappe DocField metadata (field.options) from string to list during Address quick-entry layout generation, which v16’s persistent meta cache made reproducible at insert time (unhashable list), and we fixed it by using a local options variable for UI formatting without mutating metadata.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Before:

Screen.Recording.2026-03-26.at.12.05.53.PM.mov

After:

Screen.Recording.2026-03-26.at.12.04.02.PM.mov

Checklist

• I have carefully reviewed the code before submitting it for review.
• This code is adequately covered by unit tests to validate its functionality.
• I have conducted thorough testing to ensure it functions as intended.
• A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes #2711, #2712

[Copilot]

Pull request overview

This PR fixes a Next CRM issue where generating field layouts for UI could mutate shared Frappe DocField metadata (field.options) in-place, which becomes problematic with Frappe v16’s persistent meta cache.

Changes:

• Stop mutating field.options when formatting Select options for UI output by using a local options variable.
• Expand Select option normalization to support strings (newline-separated), lists/tuples, or single values before converting to {label, value} objects.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.