ci: use public runners by default#35
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s GitHub Actions configuration so public repositories use the “public” reusable workflows by default, while still providing a separate workflow to exercise the private-workflow variants.
Changes:
- Switches
ci.ymlto call the*-public.ymlreusable workflows by default. - Adds a new
test-private-workflows.ymlworkflow to validate the private reusable workflows. - Adds an inline version comment to the Release Please action pin in
release.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/test-private-workflows.yml | New workflow that runs the CI jobs using the private reusable workflows. |
| .github/workflows/release.yml | Adds a version comment to the pinned release-please action. |
| .github/workflows/ci.yml | Defaults CI to the public reusable workflows and adjusts job wiring. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:196
build-plugin-zipruns on bothpushandpull_request, butartifact-nameis built fromgithub.event.pull_request.*. Onpushevents those fields are not present, producing an odd/empty artifact name suffix and making artifacts harder to identify. Consider using a conditional expression that falls back to${{ github.sha }}(or${{ github.run_id }}) when not running on a PR.
with:
php-version: '8.2'
artifact-name: plugin-skeleton-d-pr${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
secrets: inherit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: ./.github/workflows/reusable-build.yml | ||
| with: | ||
| php-version: '8.2' | ||
| artifact-name: plugin-skeleton-d-pr-public${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }} |
| php-version: '8.2' | ||
| artifact-name: plugin-skeleton-d-pr-public${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }} | ||
| secrets: inherit | ||
|
|
||
| playground-preview: | ||
| name: Playground Preview | ||
| needs: build-plugin-zip | ||
| if: github.event_name == 'pull_request' | ||
| uses: ./.github/workflows/reusable-wp-playground-pr-preview.yml | ||
| permissions: | ||
| actions: read | ||
| contents: write | ||
| pull-requests: write | ||
| with: | ||
| run-id: ${{ github.run_id }} | ||
| artifact-prefix: 'plugin-skeleton-d-pr-public' | ||
| artifact-filename: 'plugin-skeleton-d.zip' |
| # needs: detect | ||
| needs: phpunit |
| @@ -0,0 +1,180 @@ | |||
| # These are used by the repository to test the private workflows for the repository. | |||
| # Projects using the skeleton should remove this file, and updated the `ci.yml` workflow | |||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 94.94% 94.94%
Complexity 115 115
=========================================
Files 21 21
Lines 475 475
=========================================
Hits 451 451
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What
Defaults to use GH workflows.
Why
Private runners are for private repos.
Related Issue(s):
How
Testing Instructions
Screenshots
Additional Info
Checklist