Skip to content

ci: use public runners by default#35

Merged
justlevine merged 2 commits into
mainfrom
cli/public-runners
Apr 19, 2026
Merged

ci: use public runners by default#35
justlevine merged 2 commits into
mainfrom
cli/public-runners

Conversation

@justlevine
Copy link
Copy Markdown
Collaborator

@justlevine justlevine commented Apr 19, 2026

What

Defaults to use GH workflows.

Why

Private runners are for private repos.

Related Issue(s):

How

Testing Instructions

Screenshots

Additional Info

Checklist

Open WordPress Playground Preview

Copilot AI review requested due to automatic review settings April 19, 2026 20:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s GitHub Actions configuration so public repositories use the “public” reusable workflows by default, while still providing a separate workflow to exercise the private-workflow variants.

Changes:

  • Switches ci.yml to call the *-public.yml reusable workflows by default.
  • Adds a new test-private-workflows.yml workflow to validate the private reusable workflows.
  • Adds an inline version comment to the Release Please action pin in release.yml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/test-private-workflows.yml New workflow that runs the CI jobs using the private reusable workflows.
.github/workflows/release.yml Adds a version comment to the pinned release-please action.
.github/workflows/ci.yml Defaults CI to the public reusable workflows and adjusts job wiring.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:196

  • build-plugin-zip runs on both push and pull_request, but artifact-name is built from github.event.pull_request.*. On push events those fields are not present, producing an odd/empty artifact name suffix and making artifacts harder to identify. Consider using a conditional expression that falls back to ${{ github.sha }} (or ${{ github.run_id }}) when not running on a PR.
    with:
      php-version: '8.2'
      artifact-name: plugin-skeleton-d-pr${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
    secrets: inherit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: ./.github/workflows/reusable-build.yml
with:
php-version: '8.2'
artifact-name: plugin-skeleton-d-pr-public${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
Comment on lines +164 to +180
php-version: '8.2'
artifact-name: plugin-skeleton-d-pr-public${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
secrets: inherit

playground-preview:
name: Playground Preview
needs: build-plugin-zip
if: github.event_name == 'pull_request'
uses: ./.github/workflows/reusable-wp-playground-pr-preview.yml
permissions:
actions: read
contents: write
pull-requests: write
with:
run-id: ${{ github.run_id }}
artifact-prefix: 'plugin-skeleton-d-pr-public'
artifact-filename: 'plugin-skeleton-d.zip'
Comment thread .github/workflows/ci.yml Outdated
Comment on lines 177 to 178
# needs: detect
needs: phpunit
@@ -0,0 +1,180 @@
# These are used by the repository to test the private workflows for the repository.
# Projects using the skeleton should remove this file, and updated the `ci.yml` workflow
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.94%. Comparing base (a9b1753) to head (438b202).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #35   +/-   ##
=========================================
  Coverage     94.94%   94.94%           
  Complexity      115      115           
=========================================
  Files            21       21           
  Lines           475      475           
=========================================
  Hits            451      451           
  Misses           24       24           
Flag Coverage Δ
unit 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justlevine justlevine merged commit 665fb9c into main Apr 19, 2026
36 checks passed
@justlevine justlevine deleted the cli/public-runners branch April 19, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants