chore: update serialize javascript package to ^7.0.4#2312
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
This PR updates the Playwright E2E test package’s dependency resolutions to use serialize-javascript@^7.0.4 via npm overrides, and also bumps @wordpress/scripts.
Changes:
- Bump
@wordpress/scriptsfrom^31.5.0to^31.6.0. - Add an npm
overridesentry to forceserialize-javascriptto^7.0.4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@octokit/core": "^7.0.6", | ||
| "@octokit/plugin-paginate-rest": "^14.0.0", | ||
| "@wordpress/scripts": "^31.5.0", | ||
| "@wordpress/scripts": "^31.6.0", |
There was a problem hiding this comment.
PR description says this change updates serialize-javascript via overrides, but this also bumps @wordpress/scripts to ^31.6.0. Please confirm this dependency bump is intended and either mention it in the PR description or split it into a separate PR/commit to keep the change focused.
| "ajv": "8.18.0", | ||
| "basic-ftp": "5.2.0" | ||
| "basic-ftp": "5.2.0", | ||
| "serialize-javascript": "^7.0.4" |
There was a problem hiding this comment.
serialize-javascript@7.x declares engines.node >=20, but this package still advertises engines.node >=12. Installing this package on Node 12–19 will now fail or warn unexpectedly; please update the engines field to match the new minimum Node version (or use a serialize-javascript version compatible with the currently declared engine range).
| "serialize-javascript": "^7.0.4" | |
| "serialize-javascript": "^6.0.1" |
| "ajv": "8.18.0", | ||
| "basic-ftp": "5.2.0" | ||
| "basic-ftp": "5.2.0", | ||
| "serialize-javascript": "^7.0.4" |
There was a problem hiding this comment.
All other overrides in this file are pinned to exact versions, but serialize-javascript is specified as a range (^7.0.4). If the goal is a controlled security/compatibility bump, consider pinning it to an exact version (e.g. 7.0.4) to avoid unexpected upgrades the next time the lockfile is regenerated.
| "serialize-javascript": "^7.0.4" | |
| "serialize-javascript": "7.0.4" |
|
Resolved by #2313 |
This PR updates
serialize-javascriptpackage to^7.0.4using overrides.Resolves: https://github.com/rtCamp/rtMedia/security/dependabot/122