Skip to content

chore: update fast-xml-parser js package to ^5.3.9 #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mi5t4n wants to merge 1 commit into from
+18 −5
Closed

chore: update fast-xml-parser js package to ^5.3.9 #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tests/wp-e2e-playwright/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/wp-e2e-playwright/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"overrides": {
"webpack-dev-server": "5.2.1",
"minimatch": "10.2.1",
"fast-xml-parser": "5.3.7",
"fast-xml-parser": "^5.3.9",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this package's overrides block, all other overrides are pinned to exact versions, but fast-xml-parser is now a caret range (^5.3.9). This can cause the override target to drift on future installs and makes the lockfile version (currently 5.4.2) harder to reason about. Consider pinning fast-xml-parser to a specific version (e.g., the resolved 5.4.2, or at least an exact 5.3.9) to keep overrides deterministic and consistent with the rest of this file.

Suggested change
"fast-xml-parser": "^5.3.9",
"fast-xml-parser": "5.4.2",

Copilot uses AI. Check for mistakes.
"ajv": "8.18.0",
"basic-ftp": "5.2.0"
},
Expand All @@ -68,4 +68,4 @@
"test-e2e:playwright": "playwright test --config playwright.config.ts",
"test-e2e:playwright:dev": "npm run test-e2e:playwright -- prerequisite.spec.js && npm run test-e2e:playwright -- specs/buddypress && npm run test-e2e:playwright -- specs/display && npm run test-e2e:playwright -- specs/other_settings && npm run test-e2e:playwright -- media_size.spec.js && npm run test-e2e:playwright -- types.spec.js; npm run test-e2e:playwright -- cleanup.spec.js"
}
}
}
Loading