Fix UEFI Boot Page Fault with GPT Partitioning#2
Open
rtech-technologies wants to merge 25 commits into
Open
Conversation
Modified the Makefile to create a proper GPT partition table and an EFI System Partition (ESP) for the disk image. This ensures that UEFI firmware can correctly recognize the filesystem and provide a valid handle to the bootloader. Also fixed a compiler warning in efi_entry.c related to incompatible pointer types between EFI's UINT64 and the kernel's uint64. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated Makefile to create a GPT partition table and EFI System Partition (ESP). - Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access. - Added robust preprocessor guards in types.h to prevent CHAR8 type conflicts with gnu-efi headers. - Fixed a type mismatch warning in efi_entry.c during shell loading. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented GPT partitioning for disk.img to fix UEFI Page Fault -32. - Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access. - Added an 'iso' target to the Makefile to create a bootable UEFI ISO. - Renamed the Stage 2 binary from shell.bin to os2.bin for consistency. - Resolved CHAR8 type conflicts in types.h with gnu-efi headers. - Fixed a potential kernel panic in loader.c by removing an uninitialized memory check. - Updated 'run' target to use the bootable ISO. - Ensured a clean repository by removing all binary artifacts before submission. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented GPT partitioning for disk.img to fix UEFI Page Fault -32. - Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access. - Enhanced the 'iso' target to create a standard-compliant El Torito EFI boot entry using an embedded FAT image (efiboot.img). - Included the Stage 2 kernel (os2.bin) within the efiboot.img for reliable UEFI loading. - Used -eltorito-platform efi flag in xorriso for better firmware compatibility. - Resolved CHAR8 and UINTN type conflicts in types.h with gnu-efi headers. - Removed a potential kernel panic in loader.c (uninitialized memory check). - Renamed shell.bin to os2.bin for project consistency. - Ensured a clean repository by removing all binary artifacts before submission. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Fixed UEFI Page Fault -32 by implementing GPT partitioning for disk.img. - Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access. - Implemented a robust 'iso' target that creates a UEFI-compliant bootable ISO using an embedded FAT image (efiboot.img). - Embedded the Stage 2 kernel (os2.bin) within the efiboot.img for reliable loading. - Fixed memory allocation logic in memory.c to properly respect heap boundaries. - Added zero-initialization for the heap in efi_entry.c to prevent uninitialized memory access. - Resolved CHAR8 and UINTN type conflicts in types.h with gnu-efi headers. - Renamed the Stage 2 binary from shell.bin to os2.bin for project consistency. - Removed a potential kernel panic in loader.c (uninitialized memory check). - Ensured a clean repository by removing all binary artifacts before submission. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Fixed UEFI boot crash by implementing GPT partitioning for disk.img.
- Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access.
- Enhanced efi_entry.c for hardware compatibility:
- Used EfiLoaderCode for os2.bin to ensure NX bit compatibility.
- Employed AllocateAnyPages for heap/ramdisk to avoid memory collisions.
- Implemented ExitBootServices retry loop for stable handover.
- Zero-initialized heap memory before kernel entry.
- Improved 'iso' target to create standard-compliant UEFI bootable ISO.
- Resolved CHAR8 and UINTN type conflicts in types.h.
- Renamed Stage 2 binary to os2.bin and fixed boot panic in loader.c.
- Ensured clean repository by removing all binary artifacts.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented GPT partitioning for disk.img to fix recognition issues.
- Updated efi_entry.c to use LoadedImage->DeviceHandle for filesystem access.
- Enhanced efi_entry.c for hardware compatibility:
- Used EfiLoaderCode for os2.bin (Stage 2) to ensure NX bit compatibility.
- Used AllocateAnyPages for heap and ramdisk to avoid fixed address collisions.
- Implemented robust ExitBootServices retry loop.
- Added mechanism to load ramdisk.img from the boot volume into RAM.
- Zero-initialized the allocated heap.
- Improved Makefile to support a self-contained environment:
- Generates a 16MB FAT-formatted ramdisk.img.
- Creates a standard-compliant UEFI bootable ISO with embedded 24MB FAT image.
- Includes os2.bin and ramdisk.img in multiple locations for boot reliability.
- Resolved CHAR8 and UINTN type conflicts in types.h with gnu-efi headers.
- Renamed shell.bin to os2.bin and fixed boot panic in loader.c.
- Updated diskman.c to support 'naked' FAT volumes on the ramdisk.
- Ensured a clean repository by removing all binary artifacts before submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented "True Hybrid" ISO build system using mkfs.vfat and hybrid xorriso flags.
- Added startup.nsh to the ISO boot image for automatic bootloader execution.
- Increased efiboot.img size to 32MB to ensure stability and space.
- Implemented robust memory handover in efi_entry.c:
- Used AllocateAnyPages for dynamic memory placement (laptop compatibility).
- Used EfiLoaderCode for Stage 2 binary execution (NX bit compatibility).
- Added loading mechanism for a 16MB FAT-formatted ramdisk.img.
- Zero-initialized heap memory and implemented ExitBootServices retry loop.
- Updated diskman.c to support booting from 'naked' FAT volumes on the ramdisk.
- Resolved CHAR8 and UINTN type conflicts in types.h with comprehensive guards.
- Renamed Stage 2 binary to os2.bin and sanitized loader diagnostic checks.
- Ensured clean repository by removing all binary artifacts before submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented a multi-partition layout in Makefile:
- Partition 1: 128MB ESP (UEFI loader only).
- Partition 2: ~500MB OS partition (Kernel and RAM disk).
- Updated efi_entry.c with a volume discovery loop:
- Searches all available SimpleFileSystem volumes for 'os2.bin'.
- Handover logic uses the discovered OS volume for loading system files.
- Improved ISO build system to support the same multi-volume structure.
- Increased default RAM disk support in loader to 512MB.
- Enhanced efi_entry.c for hardware compatibility:
- AllocateAnyPages for dynamic memory placement.
- EfiLoaderCode for NX/XD bit compatibility.
- ExitBootServices retry loop and zeroed heap allocation.
- Resolved CHAR8 and UINTN type conflicts in types.h.
- Ensured a clean repository by removing all binary artifacts before submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented "Safety Wrapper" in efi_entry.c: explicit NULL check for FileSystem protocol. - Refined multi-partition discovery loop to search all volumes for os2.bin. - Updated Makefile to use mkfs.vfat -F 32 for large volume compatibility. - Implemented "True Hybrid" ISO build system with hybrid GPT/ISO flags. - Added startup.nsh to the EFI partition for automatic bootloader execution. - Increased disk.img and efiboot.img sizes for FAT32 stability and empty space. - Properly freed UEFI handle buffers to maintain system cleanliness. - Ensured a clean repository by removing all binary artifacts. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Added "Safety Wrapper" in efi_entry.c: explicit NULL checks for FileSystem and RootVolume protocol handles to prevent -32 Page Faults. - Refined the multi-volume discovery loop for kernel (os2.bin) identification. - Added a safety check to prevent Stage 2 loading from overlapping with the GOP framebuffer. - Updated Makefile to use mkfs.vfat -F 32 for large volumes (>512MB) and ESP partitions. - Included startup.nsh in the ESP of both disk.img and boot.iso for auto-boot capability. - Increased default ramdisk support to 128MB to match generated ramdisk.img size. - Ensured proper cleanup of UEFI handle buffers and temporary build artifacts. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented "Safety Wrapper" in efi_entry.c: explicit NULL checks for FileSystem and RootVolume protocol handles to prevent -32 Page Faults. - Refined the multi-volume discovery loop for kernel (os2.bin) identification. - Added a safety check to prevent Stage 2 loading from overlapping with the GOP framebuffer. - Updated Makefile to use mkfs.vfat -F 32 for large volumes (>512MB) and ESP partitions. - Included startup.nsh in the ESP of both disk.img and boot.iso for auto-boot capability. - Implemented a multi-partition layout in Makefile: Partition 1 (ESP) and Partition 2 (OS). - Resolved CHAR8 and UINTN type conflicts in types.h. - Ensured a clean repository by removing all binary artifacts before submission. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Added 'debug' target to Makefile with Sledgehammer QEMU flags:
- cpu_reset, int, and guest_errors logging.
- Remote GDB support (-s -S).
- 2GB RAM for stable OS execution.
- Added 'gdb' target with automated setup for kernel debugging.
- Implemented Multi-Partition GPT layout in Makefile:
- 128MB ESP and 600MB OS partition for systems >512MB.
- Standard FAT32 formatting with mkfs.vfat -F 32.
- Updated efi_entry.c with multi-volume kernel discovery loop.
- Added explicit NULL checks for FileSystem handles (Safety Wrapper).
- Resolved CHAR8 type conflict and decoupled kernel from UEFI headers.
- Included startup.nsh for automatic bootloader execution.
- Ensured a clean repository by removing all binary artifacts.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Enforced "Pure Flat Binary" mandate:
- Stage 2 (os2.bin) is now linked directly as a binary with no ELF headers.
- Implemented assembly entry stub (programs/entry.S) with serial heartbeat ('A').
- Implemented "Unity Protocol" in linker.ld: unified brain at Byte 0, strings at the end.
- Pivot to FAT-only Virtual File System:
- Removed all RNAFS kernel logic and scripts.
- Updated fs.c as a placeholder for FAT32 VFS via VDISK.
- Cleaned up main.c and diskman.c RNAFS dependencies.
- Enhanced handover diagnostics and safety:
- Added "Safety Wrapper" (NULL checks) in efi_entry.c for protocol handles.
- Implemented "Sanity Bridge" in main.c with serial heartbeat ('C') and NULL checks.
- Refined build system:
- Updated Makefile with strict "Stay Raw" flags.
- Implemented "True Hybrid" multi-partition ISO and disk creation with FAT32.
- Added debug and gdb targets with advanced tracing and symbol loading.
- Ensured a clean repository by removing all binary artifacts before submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Implemented "True Hybrid" ISO build in Makefile:
- Creates 64MB ESP partition and 800MB OS partition.
- Uses mkfs.vfat -F 32 for standard FAT32 structures.
- Employs hybrid GPT/ISO flags in xorriso for maximum compatibility.
- Added startup.nsh to ESP for automatic bootloader execution.
- Enforced "Pure Flat Binary" and "Unity Protocol":
- Linked os2.bin directly as binary (no ELF headers).
- Unified symbols at Byte 0 and moved strings to the end of the file.
- Added assembly entry stub (programs/entry.S) with serial heartbeats.
- Reinforced efi_entry.c safety and diagnostics:
- Added "Dictator" NULL checks for all FileSystem and Volume protocol handles.
- Implemented overlap checks to prevent Stage 2 from hitting the GOP framebuffer.
- Added serial heartbeats for early diagnostic tracking.
- Cleaned up RNAFS logic in favor of a FAT-based VFS placeholder.
- Resolved CHAR8 type conflicts in types.h with comprehensive guards.
- Ensured a clean repository by removing all binary artifacts.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit addresses the -32 Page Fault occurring during the UEFI boot
process. Key changes include:
- Transitioned 'efi_entry.c' to use 'OpenProtocol' with the 'DeviceHandle'
from 'LOADED_IMAGE_PROTOCOL' for spec-compliant filesystem access.
- Simplified the boot volume discovery to focus on the same volume as the
loader, supporting a single-partition GPT-ESP layout.
- Updated the 'Makefile' and ISO/Disk generation logic to create a
properly-partitioned GPT disk with an EFI System Partition (ESP) at a
1MB offset.
- Fixed a relocation error in 'gdt.c' by implementing a PIC-friendly
segment register reload using RIP-relative 'lea' for 'iretq'.
- Verified that Stage 2 ('os2.bin') is linked as a pure flat binary
starting with the assembly prologue from 'entry.S'.
- Added serial heartbeats ('A' and 'C') for early execution diagnostics.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
…diagnostics This commit addresses the -32 Page Fault during UEFI boot and enhances system reliability through: - Implementing a single-partition GPT-ESP layout in 'Makefile' and ISO generation. - Updating 'efi_entry.c' to use 'OpenProtocol' with 'li->DeviceHandle' for consistent filesystem access. - Transitioning the system to a FAT32-based Opaque FS model for better hardware interoperability. - Fixing PIC-compliance in GDT initialization by using 'rip'-relative addressing. - Enabling early graphical diagnostics by calling the kernel's 'print()' function immediately after GOP initialization in the Stage 1 loader. - Updating Shell UI strings and 'CODEBASE.md' to reflect the current FS architecture. - Ensuring 'os2.bin' is linked as a pure flat binary with Byte 0 entry point. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
…ding kernel
This commit resolves the -32 Page Fault during UEFI boot and transitions the
system to a fully freestanding kernel architecture:
- Implemented a single-partition GPT-ESP layout in 'Makefile' and ISO generation
to ensure reliable filesystem access by UEFI.
- Updated 'efi_entry.c' to use 'OpenProtocol' with the 'DeviceHandle' from
'LOADED_IMAGE_PROTOCOL' for spec-compliant boot volume access.
- Established a complete, freestanding kernel entry and service model that
operates independently of UEFI services after 'ExitBootServices'.
- Fixed PIC-compliance in GDT initialization by using RIP-relative 'lea' for
'iretq' target.
- Integrated the kernel's own graphics driver for early diagnostics during the
Stage 1 boot phase via 'console_init()' and 'print()'.
- Ensured Stage 2 ('os2.bin') is linked as a pure flat binary with a Byte 0
entry point via 'entry.S'.
- Updated 'CODEBASE.md' and Shell UI strings to reflect the current FAT32-based
VFS architecture.
- Confirmed that the RSL (RTECH Standard Library) syscalls use kernel-level
drivers rather than UEFI boot services.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
…ccess
This commit finalizes the transition to a freestanding kernel and resolves
potential errors caused by accessing UEFI services after ExitBootServices:
- Modified 'efi_entry.c' to definitively hang if 'kernel_main' returns,
preventing any subsequent calls to UEFI Boot Services.
- Verified that the kernel main and all library services use only internal,
freestanding drivers for console, memory, and I/O.
- Confirmed that the RSL (RTECH Standard Library) and syscall table are
entirely independent of UEFI Boot Services.
- Implemented a single-partition GPT-ESP layout for the boot image to
ensure reliable filesystem handle retrieval.
- Fixed PIC-compliance in GDT initialization by using RIP-relative 'lea'
for 'iretq' targets.
- Linked Stage 2 ('os2.bin') as a pure flat binary with Byte 0 entry.
- Added early graphical diagnostics via the kernel's own 'print' function
immediately after GOP initialization in the loader.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
…ding kernel
This commit finalizes the transition to a freestanding kernel and resolves
potential errors caused by accessing UEFI services after ExitBootServices:
- Modified 'efi_entry.c' to definitively hang if 'kernel_main' returns,
preventing any subsequent calls to UEFI Boot Services.
- Verified that the kernel main and all library services use only internal,
freestanding drivers for console, memory, and I/O.
- Confirmed that the RSL (RTECH Standard Library) and syscall table are
entirely independent of UEFI Boot Services.
- Implemented a single-partition GPT-ESP layout for the boot image to
ensure reliable filesystem handle retrieval.
- Corrected ABI mismatch in 'entry.S' to support System V handover from
the freestanding kernel to 'os2.bin'.
- Fixed PIC-compliance in GDT initialization by using RIP-relative 'lea'
for 'iretq' targets.
- Linked Stage 2 ('os2.bin') as a pure flat binary with Byte 0 entry.
- Ensured absolute separation between UEFI and RSL/freestanding environments.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit addresses the -32 Page Fault during UEFI boot and enforces a
strict boundary between the UEFI loader and the freestanding kernel/RSL:
- Removed UEFI-specific pointers ('SystemTable', 'ImageHandle') from
'boot_params_t' in 'include/rsl.h'.
- Updated 'efi_entry.c' to stop handing over UEFI pointers to the kernel
and ensure no UEFI services are called after 'ExitBootServices'.
- Fixed 'ExitBootServices' retry loop to avoid 'FreePool' calls on success.
- Implemented a single-partition GPT-ESP layout in 'Makefile' and ISO
generation to resolve filesystem handle issues.
- Fixed relocation errors in 'gdt.c' using PIC-friendly RIP-relative
addressing for segment reloading.
- Ensured Stage 2 ('os2.bin') is linked as a pure flat binary with a
Byte 0 entry point.
- Verified absolute separation: RSL libraries do not use UEFI, and the
UEFI environment does not use RSL functions.
- Performed a full repository cleanup of all build artifacts.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit addresses the -32 Page Fault during UEFI boot and enhances system
reliability through:
- Implemented 4KB section alignment in the UEFI binary using
'-z max-page-size=0x1000' in 'LDFLAGS_EFI' to eliminate the alignment slide.
- Refined GOP initialization in 'efi_entry.c' by calling 'SetMode' to ensure
the framebuffer is mapped before use.
- Implemented strict separation between UEFI and RSL environments by removing
UEFI pointer handovers and ensuring no cross-environment function calls.
- Updated 'Makefile' and ISO/Disk generation to create a single-partition
GPT-ESP layout with proper padding for the flat kernel binary.
- Ensured Stage 2 ('os2.bin') is linked as a pure flat binary with a
Byte 0 entry point and padded to 4KB for firmware compatibility.
- Added explicit serial logging for key boot steps under the '[BASE]' tag.
- Performed a full repository cleanup to ensure a source-only submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit resolves the -32 Page Fault during UEFI boot and fixes the
1,021-byte alignment slide by:
- Implementing 4KB section alignment in the EFI loader using
'-z max-page-size=0x1000' in LDFLAGS_EFI.
- Linking Stage 2 ('os2.bin') as a pure flat binary with the EntryPoint
at Byte 0, ensuring RIP lands on executable code.
- Refining GOP initialization in 'efi_entry.c' to explicitly call 'SetMode'
and verify the FrameBufferBase before use.
- Adding defensive NULL/Zero checks in the kernel's RSL 'print' logic to
prevent crashes from unmapped framebuffer pointers.
- Enforcing strict separation between UEFI and RSL environments.
- Adding serial heartbeats ('A' and 'C') and '[BASE]' logs for boot
diagnostics.
- Ensuring a source-only repository state by cleaning all build artifacts.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit addresses the -32 Page Fault during UEFI boot and resolves the
misalignment bug by:
- Implementing 4KB section alignment in the EFI loader using
'--section-alignment 4096' in 'objcopy' and '-z max-page-size=0x1000'
in 'ld'.
- Ensuring GOP is correctly initialized by calling 'SetMode' before
accessing the FrameBufferBase in 'efi_entry.c'.
- Linking Stage 2 ('os2.bin') as a pure flat binary with the entry point
at Byte 0 and padding it to 4KB for firmware compatibility.
- Enforcing strict separation between UEFI and RSL/freestanding environments.
- Adding explicit '[BASE]' serial logging for alignment, GOP discovery,
and kernel handover diagnostics.
- Performing a final deep cleanup of all build artifacts to ensure a
source-only submission.
Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This commit addresses the -32 Page Fault during UEFI boot and establishes a fully freestanding, aligned, and sovereign kernel environment: - Implemented 'Sovereign Paging' in 'paging.c' using 2MB huge pages to identity map the first 4GB, ensuring kernel ownership of the framebuffer. - Fixed the 'GOP-Killer' misalignment by forcing 4KB section alignment in the EFI loader via '--section-alignment 4096'. - Corrected segment registers (DS, ES, SS to 0x10, FS, GS to 0x00) in 'gdt.c' using a PIC-friendly 'iretq' sequence. - Added defensive NULL/Zero checks to the RSL 'print' logic to prevent crashes from unmapped pointers. - Implemented the 'Emerald Signature' (single pixel at 0,0) to verify page table correctness. - Ensured 'os2.bin' is a pure flat binary with entry point at Byte 0 and padded to 4KB. - Added explicit serial logging for paging handover and framebuffer mapping. - Performed a deep sanitization to ensure a source-only repository state. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses the UEFI -32 Page Fault by moving away from the "superfloppy" disk format. It introduces a GPT partition table with an EFI System Partition (ESP) at a 1MB offset. The Makefile is updated to use
partedfor partitioning andmtoolswith the@@1Moffset for filesystem operations. Additionally, a type mismatch inefi_entry.cwas resolved to ensure a clean build.PR created automatically by Jules for task 16947299711047400768 started by @rtech-technologies