Skip to content

docs: align Rust guide structure with JS#4

Merged
alejnp merged 8 commits intomasterfrom
feature/user-guide-initial
Jan 19, 2026
Merged

docs: align Rust guide structure with JS#4
alejnp merged 8 commits intomasterfrom
feature/user-guide-initial

Conversation

@alexcamposruiz
Copy link
Copy Markdown
Contributor

@alexcamposruiz alexcamposruiz commented Jan 12, 2026

Summary

  • Reworked Rust docs to align with JS doc structure while staying accurate to the Rust API.
  • Expanded guide content for configuration, connector lifecycle, input/output workflows, data access, errors, threading, and advanced operations.
  • Incorporated previous content
  • Cleaned up crate index to a consistent TOC plus API Overview.

Details

Where Previous Content Moved

  • Overview / API summary: now under “API Overview” on the crate index.
  • Build-time linking details: now in docs/guide/getting_started.md.
  • Typed data support: now in docs/guide/data.md.
  • Error handling: now in docs/guide/errors.md.
  • Thread safety: now in docs/guide/threading.md.

Areas Needing More Work

JS Parity Gaps

These are potential improvements, but may not be necessary for now:

  • Configuration: JS includes a deeper XML/IDL walkthrough and more tag‑by‑tag mapping; Rust version is shorter.
  • Data access: JS includes local field‑name syntax examples and a large XML/IDL sample; Rust relies on external links.
  • Threading: JS lists specific safe/unsafe operations and reentrancy caveats; Rust guide is high‑level.
  • Error handling: JS shows richer error classes/scenarios; Rust guide has fewer concrete cases.
  • Advanced: JS has a richer “features” content tree; Rust guide is a concise checklist.

Other

  • Move Rust snippets in docs to .rs files and include them in .md so they can be compiled
  • Expand concrete XML/IDL examples in Configuration and Data access.
  • Add more “common failure modes” examples in Error handling.
  • Clarify any Rust threading guarantees if an authoritative contract exists.
  • Document matched publication/subscription JSON formats.

@alexcamposruiz alexcamposruiz requested review from alejnp and Copilot and removed request for Copilot January 12, 2026 20:25
Comment thread src/lib.rs Outdated
Comment thread docs/result.md Outdated
Comment thread docs/output.md Outdated
Comment thread docs/lib.md
Comment thread docs/lib.md Outdated
Comment thread docs/guide/output.md
Comment thread docs/guide/index.md
Comment thread docs/guide/connector.md Outdated
Comment thread docs/connector.md Outdated
@alejnp alejnp requested a review from lloadholt January 14, 2026 11:52
@alejnp
Copy link
Copy Markdown
Member

alejnp commented Jan 14, 2026

My biggest concern with this is the added maintainability burden (external URLs, duplicated content), but otherwise I'm okay with keeping it if deemed useful for customers.

@lloadholt I've added you as reviewer because most of this is documentation. You can find the internal-only, built documentation here.

Copilot AI review requested due to automatic review settings January 14, 2026 11:55

This comment was marked as resolved.

@alexcamposruiz
Copy link
Copy Markdown
Contributor Author

My biggest concern with this is the added maintainability burden (external URLs, duplicated content), but otherwise I'm okay with keeping it if deemed useful for customers.

@lloadholt I've added you as reviewer because most of this is documentation. You can find the internal-only, built documentation here.

Duplication is a concern, but is something we long ago decided was a lesser evil in the Connectors. Trying to consolidate docs for all Connectors would be harder to implement and maintain that some limited duplication.

@alexcamposruiz
Copy link
Copy Markdown
Contributor Author

My biggest concern with this is the added maintainability burden (external URLs, duplicated content), but otherwise I'm okay with keeping it if deemed useful for customers.

@lloadholt I've added you as reviewer because most of this is documentation. You can find the internal-only, built documentation here.

@lloadholt - Most of this documentation is adapted from the JavaScript connector, so I don't think it requires a deep review.

@alexcamposruiz alexcamposruiz requested a review from alejnp January 14, 2026 19:45
Copy link
Copy Markdown
Collaborator

@lloadholt lloadholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented through 'getting-started.md'.

Comment thread docs/guide/configuration.md Outdated
Comment thread docs/guide/configuration.md Outdated
Comment thread docs/guide/configuration.md Outdated
Comment thread docs/guide/configuration.md Outdated
Comment thread docs/guide/connector.md Outdated
Comment thread docs/guide/getting_started.md
Comment thread docs/guide/getting_started.md Outdated
Comment thread docs/guide/getting_started.md Outdated
Comment thread docs/guide/getting_started.md
Comment thread docs/guide/getting_started.md Outdated
Copy link
Copy Markdown
Collaborator

@lloadholt lloadholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented remaining md files (index.md through result.md)

Comment thread docs/guide/input.md
Comment thread docs/guide/input.md
Comment thread docs/guide/input.md Outdated
Comment thread docs/guide/input.md Outdated
Comment thread docs/guide/input.md Outdated
Comment thread docs/guide/output.md Outdated
Comment thread docs/guide/output.md Outdated
Comment thread docs/guide/threading.md
Comment thread docs/guide/threading.md Outdated
Comment thread docs/input.md Outdated
@alexcamposruiz

This comment was marked as resolved.

@lloadholt
Copy link
Copy Markdown
Collaborator

@alexcamposruiz No further comments on the content.

Is it ok for me to edit these files (and the Connector for JavaScript manual) directly to apply RTI style? Primarily, I'd like to change the text format for the following words to match the format used in other RTI user manuals:

  • Topics
  • DataReader (replace all instances of "reader")
  • DataWriter (replace all instances of "writer")
  • RTI Connector
  • Publisher
  • Subsriber

@alexcamposruiz
Copy link
Copy Markdown
Contributor Author

alexcamposruiz commented Jan 15, 2026

@alexcamposruiz No further comments on the content.

Is it ok for me to edit these files (and the Connector for JavaScript manual) directly to apply RTI style? Primarily, I'd like to change the text format for the following words to match the format used in other RTI user manuals:

  • Topics
  • DataReader (replace all instances of "reader")
  • DataWriter (replace all instances of "writer")
  • RTI Connector
  • Publisher
  • Subsriber

@lloadholt Sure. Can you approve this PR and create new ones with your edits?

@alejnp
Copy link
Copy Markdown
Member

alejnp commented Jan 19, 2026

I am merging this PR and deleting the branch. In the future, prefer making the changes in your own clone, to avoid issues with rulesets and avoid polluting the .git of the main repository.

@alejnp alejnp merged commit 2b9e79c into master Jan 19, 2026
@alejnp alejnp deleted the feature/user-guide-initial branch January 19, 2026 09:46
alejnp added a commit that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants