fix(copilot): add missing 'get' to kubectl example in init template#2472
Open
K0IN wants to merge 1 commit into
Open
fix(copilot): add missing 'get' to kubectl example in init template#2472K0IN wants to merge 1 commit into
K0IN wants to merge 1 commit into
Conversation
The COPILOT_INSTRUCTIONS template translated 'kubectl get pods' to 'rtk kubectl pods', dropping the 'get' subcommand. This caused Copilot agents to run 'rtk kubectl pods' which fails since rtk expects 'rtk kubectl get pods'. Fix: change 'rtk kubectl pods' to 'rtk kubectl get pods' in the COPILOT_INSTRUCTIONS template string. Add regression test to prevent this class of typo in the future. Signed-off-by: K0IN <thisk0in@gmail.com>
|
|
Author
|
i wasnt sure if a regression test is needed, but i included one anyway, if you dont like it, i can remove it :) |
TaKO8Ki
self-requested a review
July 16, 2026 16:20
TaKO8Ki
reviewed
Jul 16, 2026
Collaborator
There was a problem hiding this comment.
Thank you for the contribution. I think rtk kubectl pods is a shorthand of rtk kubectl get pods. I expect the rewrite passes. What errors did you get with rtk on GitHub Copilot?
ref: https://github.com/rtk-ai/rtk/blob/develop/README.md#containers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The COPILOT_INSTRUCTIONS template translated 'kubectl get pods' to 'rtk kubectl pods', dropping the 'get' subcommand. This caused Copilot agents to run 'rtk kubectl pods' which fails since rtk expects 'rtk kubectl get pods'.
Fix: change 'rtk kubectl pods' to 'rtk kubectl get pods' in the COPILOT_INSTRUCTIONS template string.
Add regression test to prevent this class of typo in the future.
Summary
Fix the tempalte to be a faithfull translation of the input and add regression tests.
Fixes #2471
Test plan
ran a debug build, and used rtk init --copilot
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected