fix(hook): preserve explicit linter rewrites#3017
Open
ychampion wants to merge 1 commit into
Open
Conversation
Constraint: explicit package-manager invocations must retain the requested linter identity. Rejected: tighten generic linter detection | would change direct rtk lint extensibility beyond this bug. Confidence: high Scope-risk: narrow Directive: keep generic lint-script rewrites on the existing auto-detection path. Tested: cargo fmt --all --check; cargo clippy --all-targets --locked -- -D warnings; cargo test --locked; manual Biome, ESLint, and generic lint hook checks. Signed-off-by: Yashas Gunderia <68075205+ychampion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2906
Summary
biomeandeslintin hook rewrites when the command names them explicitlylintscript rewrites on the existing auto-detection pathTest plan
cargo fmt --all --check && cargo clippy --all-targets --locked -- -D warnings && cargo test --lockedrtk hook check "pnpm exec biome ci ."->rtk lint biome ci .