fix(find): preserve native type defaults#3019
Open
ychampion wants to merge 1 commit into
Open
Conversation
Native find syntax should match both files and directories unless a type predicate is explicitly supplied. Keep the RTK shorthand files-only default unchanged. Constraint: Preserve existing RTK shorthand and explicit -type behavior. Rejected: Changing the shared FindArgs default | It would alter shorthand semantics outside the reported bug. Confidence: high Scope-risk: narrow Directive: Keep native and shorthand defaults separate unless the CLI contract changes. Tested: cargo fmt --all -- --check; cargo clippy --all-targets --locked; cargo test --locked; cargo build --locked; focused find tests; manual CLI smoke Signed-off-by: ychampion <ychampion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findsyntax when-typeis omitted.-type f/-type dbehavior.Why
Native
finddoes not apply a type filter unless one is requested. RTK inherited its shorthand files-only default, so directory-only searches could silently return nothing.Closes #3016.
Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --lockedcargo test --lockedcargo build --lockedrtk findchecks with omitted, file, and directory type filters