fix(learn): ignore parallel tool call cancellations#3024
Open
houtinghang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk learnerror classification.Root cause
is_command_errorfiltered explicit user-rejection phrases, but did not recognize:Because the payload contains
errored, it passed the generic error-content check.find_correctionsthen treated the next sibling command as a successful replacement and generated a falseUse X not Yrule.Impact
Cancelled parallel work is now excluded before correction pairing, preventing false rules from dominating generated
cli-corrections.mdfiles.Fixes #1659.
Validation
cargo test learn::detector::tests:: -- --nocapture— 16 passed.cargo fmt --all --check— passed.cargo clippy --all-targets— passed.%APPDATA%writes or expects Unix commands. Nolearntests failed.